On Tue, Aug 20, 2019 at 01:17:59PM +0200, Juan Quintela wrote: > Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote: > >> Current parameter was always one. We continue with that value for now > >> in all callers. > >> > >> Signed-off-by: Juan Quintela <quint...@redhat.com> > >> > >> --- > >> Moved trace to socket_listen > >> --- > >> include/qemu/sockets.h | 2 +- > >> io/channel-socket.c | 2 +- > >> qga/channel-posix.c | 2 +- > >> tests/test-util-sockets.c | 12 ++++++------ > >> util/qemu-sockets.c | 33 ++++++++++++++++++++++----------- > >> util/trace-events | 3 +++ > >> 6 files changed, 34 insertions(+), 20 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > > Hi > > Everything is reviewed by you, and it is mostly socket code. Should I > do the pull request, or are you doing it?
I'm fine if you want to send a PR, since this is ultimately about fixing migration problems. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|