On 10/4/19 11:39 AM, Max Reitz wrote:
> On 18.09.19 01:45, John Snow wrote:
>> This series uses python logging to enable output conditionally on
>> iotests.log(). We unify an initialization call (which also enables
>> debugging output for those tests with -d) and then make the switch
>> inside of iotests.
>>
>> It will help alleviate the need to create logged/unlogged versions
>> of all the various helpers we have made.
>>
>> V5:
>> - Rebased again
>> - Allow Python tests to run on any platform
>>
>> V4:
>> - Rebased on top of kwolf/block at the behest of mreitz
>>
>> V3:
>> - Rebased for 4.1+; now based on main branch.
>>
>> V2:
>> - Added all of the other python tests I missed to use script_initialize
>> - Refactored the common setup as per Ehabkost's suggestion
>> - Added protocol arguments to common initialization,
>> but this isn't strictly required.
>
> I’m OK to take the series as-is (it doesn’t affect any auto tests, so we
> can decide what to do about non-Linux platforms in make check at a later
> point), but there seems to be something you wanted to fix up in patch 5.
>
> (And there’s also Kevin’s pending pull request that changes a bit of
> iotests.py.)
>
> Max
>
Just caught up with the discussion.
It looks like Thomas took my 1/5; so I'll respin on top of his "[PATCH
0/5] Enable more iotests during "make check-block" series to catch those
improvements as they stand.
--js
