14.10.2019 13:11, Vladimir Sementsov-Ogievskiy wrote: > 13.10.2019 23:48, Alberto Garcia wrote: >> The BDRV_REQ_NO_FALLBACK flag means that an operation should only be >> performed if it can be offloaded or otherwise performed efficiently. > > As I know, BDRV_REQ_NO_FALLBACK is for write-zeros only, not about > offloading.. > >> >> However a misaligned write request requires a RMW so we should return >> an error and let the caller decide how to proceed. > > Because we can finish up with trying to to normal write (not write_zero) with > BDRV_REQ_NO_FALLBACK flag, which is forbidden for bdrv_driver_pwritev, as it's > shown in assertion below. >
Haha, I'm too late, see it's already queued, sorry. -- Best regards, Vladimir
