On 11.10.19 16:50, Thomas Huth wrote: > 041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as > only supported on these systems. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > tests/qemu-iotests/041 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 > index 8568426311..7211f1950a 100755 > --- a/tests/qemu-iotests/041 > +++ b/tests/qemu-iotests/041 > @@ -1123,4 +1123,5 @@ class TestOrphanedSource(iotests.QMPTestCase): > > if __name__ == '__main__': > iotests.main(supported_fmts=['qcow2', 'qed'], > - supported_protocols=['file']) > + supported_protocols=['file'], > + supported_platforms=['linux', 'freebsd', 'openbsd6'])
Hmm, why not just “openbsd”, or single out macOS as unsupported? (I suppose the latter would require an additional patch.) There’s also the fact that I maybe wanted to let make check skip all tests on macOS and Windows – though that doesn’t make this patch unnecessary, because that would only fix make check, not running the iotests explicitly. And I suppose maybe we even want to run the tests in macOS if it’s part of the CI anyway? Max
signature.asc
Description: OpenPGP digital signature
