On 17.10.19 15:01, Kevin Wolf wrote: > Add a --export option to qemu-storage-daemon to export a block node. For > now, only NBD exports are implemented. Apart from the 'type' option > (which is the implied key), it maps the arguments for nbd-server-add to > the command line. Example: > > --export nbd,device=disk,name=test-export,writable=on > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > qapi/block.json | 27 +++++++++++++++++++++++++++ > qemu-storage-daemon.c | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+)
Would it be better to collect the BlockExports in a list and work on it after all arguments have been parsed? As it is, it’s important that users define block devices and things like NBD servers before --export. Yes, I know, that’s exactly how it works with qemu, but is that really the best way? Max
signature.asc
Description: OpenPGP digital signature
