20.01.2020 13:55, Max Reitz wrote: > On 19.12.19 11:03, Vladimir Sementsov-Ogievskiy wrote: >> The function is definitely internal (it's not used by third party and >> it has complicated interface). Move it to .c file. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> >> --- >> include/qemu/hbitmap.h | 30 ------------------------------ >> util/hbitmap.c | 29 +++++++++++++++++++++++++++++ >> 2 files changed, 29 insertions(+), 30 deletions(-) > > I wonder why you removed the “inline”, but then again we should probably > trust the compiler more than our intuition anyway.
Hmm, somehow, I was sure, that defining "static inline" functions in .c file is equal to defining them just "static", as compiler will decide inline it or not it on its own anyway.. May be I'm wrong. At least it's claimed that compiler may ignore "inline", so it's a hing, and on the other hand it may inline not "inline" function. And even if I'm wrong, I agree that in non-critical cases we should trust the compiler optimization strategy. > > Reviewed-by: Max Reitz <[email protected]> > -- Best regards, Vladimir
