On Tue, 2020-01-28 at 17:23 +0000, Daniel P. Berrangé wrote:
> On Tue, Jan 14, 2020 at 09:33:41PM +0200, Maxim Levitsky wrote:
> > Some options are only useful for creation
> > (or hard to be amended, like cluster size for qcow2), while some other
> > options are only useful for amend, like upcoming keyslot management
> > options for luks
> >
> > Since currently only qcow2 supports amend, move all its options
> > to a common macro and then include it in each action option list.
> >
> > In future it might be useful to remove some options which are
> > not supported anyway from amend list, which currently
> > cause an error message if amended.
>
> I think I would have done that in this commit. At least the
> encrypt.* options shouldn't be added to the amend_opts list,
> since they're being removed from it again a few patches later.
After taking on IRC, I understood the point.
I indeed will send another patch after this one that will
only cleanup qcow2 amend/create options and then patch that
adds luks amend to qcow2, thus 3 patches in total, this one,
the patch that cleans the create/amend separation and then
patch that adds luks amend to qcow2.
[...]
Thanks for the review,
Best regards,
Maxim Levitsky
