On 11/1/19 12:55 PM, Sven Schnelle wrote: > While working on the Tulip driver i tried to write some Teledisk images to > a floppy image which didn't work. Turned out that Teledisk checks the written > data by issuing a READ command to the FDC but running the DMA controller > in VERIFY mode. As we ignored the DMA request in that case, the DMA transfer > never finished, and Teledisk reported an error. > > The i8257 spec says about verify transfers: > > 3) DMA verify, which does not actually involve the transfer of data. When an > 8257 channel is in the DMA verify mode, it will respond the same as described > for transfer operations, except that no memory or I/O read/write control > signals > will be generated. > > Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more > clear boundary between DMA and FDC, so this patch also does that. > > Suggested-by: Hervé Poussineau <[email protected]> > Signed-off-by: Sven Schnelle <[email protected]> I know it's many many moons later; I was out of the country for a month when this patch arrived, and I lost track of it under my email backlog. It looks reviewed and good to go, so I am staging it locally and testing it. Thanks, --js
