On Sat, 21 Mar 2020, Aleksandar Markovic wrote:
On Saturday, March 21, 2020, Philippe Mathieu-Daudé <[email protected]> wrote:Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- hw/ide/sii3112.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index 06605d7af2..36f1905ddb 100644 --- a/hw/ide/sii3112.c +++ b/hw/ide/sii3112.c @@ -125,7 +125,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr, val = (uint32_t)d->regs[1].sien << 16; break; default: - val = 0; + break;There is another function in the same file, having a similar switch statement. There is no warning for that second tunction, since "val" is its parameter, not a local varioble, like is the case here. This means that the proposed change introduces inconsistency between two functions, therefore it is better to remove the initialization of "val" to 0, than to remove this line in "default" section.
Oh, actually I think the warning was for that statement not for the one patched as it makes more sense there where val is assigned in void sii3112_reg_write() where it's indeed not used so maybe that was meant to be patched instead?
Regards, BALATON Zoltan
