Hi Kevin, I'm hoping to get some preliminary ideas from you (capped at five minutes' effort?) on this subject. My ideas here are a bit shaky, I only have really rough notions here.
We want to use bitmaps with 'drive' semantics; i.e. tracking changes to the visible guest data. What we have are bitmaps with node semantics, tracking changes to the data at a particular level in the graph. For commit, this isn't a big deal: we can disable bitmaps in the backing file while we commit and then re-enable it on completion. We usually have a separate bitmap enabled on the root node that is recording writes during this time, and can be moved later. For streaming, this is more challenging: new writes will dirty the bitmap, but so will writes from the stream job itself. Semantically, we want to ignore writes from the stream while recording them from the guest -- differentiating based on source. Bitmaps aren't really geared to do that right now. With the changes to Bdrv Roles that Max was engineering, do you think it's possible to add some kind of write source discrimination to bitmaps, or is that too messy? For both commit and stream, it might be nice to say: "This bitmap is enabled, but ignores writes from [all? specific types? specific instances?] jobs. Or, I wonder if what we truly want is some kind of bitmap "forwarder" object on block-backend objects that represent the semantic drive view, and only writes through that *backend* get forwarded to the bitmaps attached to whatever node the bitmap is actually associated with. (That might wind up causing weird problems too, though... since those objects are no longer intended to be user-addressable, managing that configuration might get intensely strange.) Let me know if you have any quick thoughts. --js
