Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for-5.1 0/8] qemu-option: Fix corner cases and clean up Message-id: [email protected] Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 505f5f3 qemu-option: Move is_valid_option_list() to qemu-img.c and rewrite b164930 qemu-img: Factor out accumulate_options() helper b7fcaae test-qemu-opts: Simplify test_has_help_option() after bug fix 6845c29 qemu-option: Fix has_help_option()'s sloppy parsing 5c1b2db qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily() b3630a3 qemu-option: Fix sloppy recognition of "id=..." after ", , " 8bb805d qemu-options: Factor out get_opt_name_value() helper 2e00310 tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt() === OUTPUT BEGIN === 1/8 Checking commit 2e003109273b (tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()) WARNING: Block comments use a leading /* on a separate line #37: FILE: tests/test-qemu-opts.c:747: + { "a,b,,help", false /* BUG */, true, true }, total: 0 errors, 1 warnings, 50 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit 8bb805dd3730 (qemu-options: Factor out get_opt_name_value() helper) 3/8 Checking commit b3630a346906 (qemu-option: Fix sloppy recognition of "id=..." after ", , ") 4/8 Checking commit 5c1b2db0b7ad (qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily()) 5/8 Checking commit 6845c29bee11 (qemu-option: Fix has_help_option()'s sloppy parsing) 6/8 Checking commit b7fcaaeeeb6f (test-qemu-opts: Simplify test_has_help_option() after bug fix) 7/8 Checking commit b164930d4c8d (qemu-img: Factor out accumulate_options() helper) 8/8 Checking commit 505f5f389855 (qemu-option: Move is_valid_option_list() to qemu-img.c and rewrite) ERROR: suspect code indent for conditional statements (4, 4) #61: FILE: qemu-img.c:243: + for (i = len; i > 0 && optarg[i - 1] == ','; i--) { + } total: 1 errors, 0 warnings, 67 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
