On 08/05/20 08:24, Philippe Mathieu-Daudé wrote: > It is not clear if dccvap_writefn() really needs > memory_region_writeback() or could use memory_region_msync().
Indeed, I don't understand the code and why it matters that mr->dirty_log_mask is nonzero. mr->dirty_log_mask tells if dirty tracking has been enabled, not if the page is dirty. It would always be true during live migration and when running on TCG, but otherwise it would always be false. Beata, can you explain what you had in mind? :) Paolo
