Please ignore the series, I forgot xen-block device. Roman.
On Tue, May 26, 2020 at 11:17:35AM +0300, Roman Kagan wrote: > BlockConf includes several properties counted in bytes. > > Enhance their handling in a some aspects, specifically > > - accept common size suffixes (k, m) > - perform consistency checks on the values, to prevent their silent > truncation and rounding > - lift the upper limit on physical_block_size and logical_block_size > > Also fix the accessor for opt_io_size in virtio-blk to make it match the size > of the field. > > History: > v4 -> v5: > - re-split the patches [Philippe] > - fix/reword error messages [Philippe, Kevin] > - do early return on failed consistency check [Philippe] > - use QEMU_IS_ALIGNED instead of open coding [Philippe] > - make all BlockConf size props support suffixes > - expand the log for virtio-blk opt_io_size [Michael] > > v3 -> v4: > - add patch to fix opt_io_size width in virtio-blk > - add patch to perform consistency checks [Kevin] > - check min_io_size against truncation [Kevin] > > v2 -> v3: > - mention qcow2 cluster size limit in the log and comment [Eric] > > v1 -> v2: > - cap the property at 2 MiB [Eric] > - accept size suffixes > > Roman Kagan (5): > virtio-blk: store opt_io_size with correct size > block: consolidate blocksize properties consistency checks > qdev-properties: blocksize: use same limits in code and description > block: make size-related BlockConf properties accept size suffixes > block: lift blocksize property limit to 2 MiB > > include/hw/block/block.h | 18 +- > include/hw/qdev-properties.h | 2 +- > hw/block/block.c | 64 ++++- > hw/block/fdc.c | 5 +- > hw/block/nvme.c | 5 +- > hw/block/virtio-blk.c | 9 +- > hw/core/qdev-properties.c | 109 +++---- > hw/ide/qdev.c | 5 +- > hw/scsi/scsi-disk.c | 12 +- > hw/usb/dev-storage.c | 5 +- > tests/qemu-iotests/172.out | 532 +++++++++++++++++------------------ > 11 files changed, 423 insertions(+), 343 deletions(-) > > -- > 2.26.2 > >
