On 5/14/20 7:53 AM, John Snow wrote: > mypy considers it incorrect to use `bool` to statically return false, > because it will assume that it could conceivably return True, and gives > different analysis in that case. Use a None return to achieve the same > effect, but make mypy happy. > > Note: Pylint considers function signatures as code that might trip the > duplicate-code checker. I'd rather not disable this as it does not > trigger often in practice, so I'm disabling it as a one-off and filed a > change request; see https://github.com/PyCQA/pylint/issues/3619 > > Signed-off-by: John Snow <[email protected]> > --- > python/qemu/lib/machine.py | 8 ++++++-- > python/qemu/lib/qmp.py | 10 ++++++++-- > 2 files changed, 14 insertions(+), 4 deletions(-)
Thanks, applied to my python-next tree: https://gitlab.com/philmd/qemu/commits/python-next
