Alex Bennée <[email protected]> writes:
> From: Vladimir Sementsov-Ogievskiy <[email protected]> > > It is possible, that shutdown on target occurs earlier than migration > finish. In this case we crash in bdrv_release_dirty_bitmap_locked() > on assertion "assert(!bdrv_dirty_bitmap_busy(bitmap));" as we do have > busy bitmap, as bitmap migration is ongoing. > > We'll fix bitmap migration to gracefully cancel on early shutdown soon. > Now let's fix iotest 194 to wait migration completion before shutdown. > > Note that in this test dest_vm.shutdown() is called implicitly, as vms > used as context-providers, see __exit__() method of QEMUMachine class. > > Actually, not waiting migration finish is a wrong thing, but the test > started to crash after commit ae00aa239847682 > "iotests: 194: test also migration of dirty bitmap", which added dirty > bitmaps here. So, Fixes: tag won't hurt. > > Fixes: ae00aa2398476824f0eca80461da215e7cdc1c3b > Reported-by: Thomas Huth <[email protected]> > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > Tested-by: Thomas Huth <[email protected]> > Reviewed-by: Eric Blake <[email protected]> > Signed-off-by: Alex Bennée <[email protected]> > Message-Id: <[email protected]> Obviously this patch isn't going in via plugins/next - I had it in my tree to keep CI green and forgot to take that into account when generating the series! -- Alex Bennée
