On Thu, Jun 25, 2020 at 08:48:38PM +0200, Philippe Mathieu-Daudé wrote:
> @@ -529,10 +529,13 @@ static bool nvme_poll_queues(BDRVNVMeState *s)
> bool progress = false;
> int i;
>
> + if (s->plugged) {
> + return false;
> + }
> for (i = 0; i < s->nr_queues; i++) {
> NVMeQueuePair *q = s->queues[i];
> qemu_mutex_lock(&q->lock);
> - while (nvme_process_completion(s, q)) {
> + while (nvme_process_completion(q)) {
> /* Keep polling */
> progress = true;
> }This code transformation is correct but I hope plugged can be removed from the completion code path in the future since its purpose is for batching submissions. Reviewed-by: Stefan Hajnoczi <[email protected]>
signature.asc
Description: PGP signature
