On 29.06.20 14:05, Maxim Levitsky wrote: > On Thu, 2020-06-25 at 14:55 +0200, Max Reitz wrote: >> From: Maxim Levitsky <mlevi...@redhat.com> >> >> This commit adds two tests, which test the new amend interface >> of both luks raw images and qcow2 luks encrypted images. >> >> Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> >> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> >> [mreitz: Let 293 verify that LUKS works; drop $(seq) usage from 293; >> drop 293 and 294 from the auto group] >> Signed-off-by: Max Reitz <mre...@redhat.com> >> --- >> tests/qemu-iotests/293 | 208 +++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/293.out | 99 ++++++++++++++++++ >> tests/qemu-iotests/294 | 90 ++++++++++++++++ >> tests/qemu-iotests/294.out | 30 ++++++ >> tests/qemu-iotests/group | 2 + >> 5 files changed, 429 insertions(+) >> create mode 100755 tests/qemu-iotests/293 >> create mode 100644 tests/qemu-iotests/293.out >> create mode 100755 tests/qemu-iotests/294 >> create mode 100644 tests/qemu-iotests/294.out
[...] >> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group >> index d886fa0cb3..b945dd4f20 100644 >> --- a/tests/qemu-iotests/group >> +++ b/tests/qemu-iotests/group >> @@ -301,4 +301,6 @@ >> 290 rw auto quick >> 291 rw quick >> 292 rw auto quick >> +293 rw >> +294 rw quick >> 297 meta > > I guess now we can add these to 'auto' group? Have you run them on all platforms? I haven’t. (I have run the openbsd build, but I’m not even sure I had these tests in auto at that point. And that build takes a really long time.) All in all, I don’t think I ever want to add a test to auto again, unless it’s done in a specific patch where the author guarantees they tested it everywhere. Max
signature.asc
Description: OpenPGP digital signature