On Wed, Jul 08, 2020 at 04:06:45PM +0300, Maxim Levitsky wrote: > On Wed, 2020-07-08 at 14:33 +0200, Gerd Hoffmann wrote: > > On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote: > > > blockdev-amend will be used similiar to blockdev-create > > > to allow on the fly changes of the structure of the format based block > > > devices. > > > > This one breaks the build: > > > > In file included from > > /home/kraxel/projects/qemu/include/block/throttle-groups.h:29, > > from > > /home/kraxel/projects/qemu/include/sysemu/block-backend.h:17, > > from /home/kraxel/projects/qemu/qemu-img.c:46: > > /home/kraxel/projects/qemu/include/block/block_int.h:154:39: error: unknown > > type name ‘BlockdevAmendOptions’; did you mean ‘BlockdevAioOptions’? > > BlockdevAmendOptions *opts, > > ^~~~~~~~~~~~~~~~~~~~ > > BlockdevAioOptions > > make: *** [/home/kraxel/projects/qemu/rules.mak:69: qemu-img.o] Error 1 > > > > take care, > > Gerd > > > > Apparently I didn't add #include of qapi-types-block-core.h in block_int.h > (I'll fix this in a patch soon), > but it looks like throttle-groups.h includes "qemu/throttle.h" which includes > "qapi/qapi-types-block-core.h", > so it should be included explicitly here.
Ok, scratch that. Seems this came from stale files still being around from an in-tree build. Dunno how that happened, usually I do out-of-tree builds exclusively. sorry for the extra work, Gerd
