On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > Add script to benchmark new backup architecture. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > --- > scripts/simplebench/bench-backup.py | 132 ++++++++++++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100755 scripts/simplebench/bench-backup.py
Looks reasonable. Not sure whether I can give an R-b, given my non-existing background on the simplebench scripts, and also that it’s probably not really necessary. The only thing that sprung to my eye is that you give x-use-copy-range even when the “new” label isn’t given, which may be a problem. (Because AFAIU, the “new” label means that qemu is sufficiently new to support x-max-workers; and that’s basically equivalent to supporting x-use-copy-range.) Max
signature.asc
Description: OpenPGP digital signature
