On Fri, Aug 21, 2020 at 11:40:12AM +0200, David Hildenbrand wrote: > On 20.08.20 23:55, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is not set, despite having type > > checker macros that use a specific type. > > > > The ones with "WARNING" are abstract types (maybe not serious if > > subclasses set the appropriate sizes). The ones with "ERROR" > > don't seem to be abstract types. [...] > > ERROR: hw/s390x/virtio-ccw.c:1237:1: class_size should be set to > > sizeof(VirtioCcwBusClass)? > > The parent of TYPE_VIRTIO_CCW_BUS is TYPE_VIRTIO_BUS. > > typedef struct VirtioBusClass VirtioCcwBusClass; > > So I guess the sizes match? Anyhow, setting doesn't hurt.
Thanks for checking. Yeah, the sizes match today. It's a good idea to set it, just in case a real VirtioCcwBusClass struct gets created one day. -- Eduardo
