On Mon, Sep 07, 2020 at 01:02:16PM +0200, Klaus Jensen wrote: > On Sep 7 11:52, Dr. David Alan Gilbert wrote: > > > It may be best to turn it into a constant in include/hw/pci/pci_ids.h if > > it corresponds to some real Intel device. > > > > Yes, but that is just the thing - it does not correspond to an > officially allocated device; which is why I think we should leave it out > of pci_ids.h. > > The end goal is to get rid of its use in the code by deprecating the > use-intel-id parameter in the future. I guess the parameter should just > be deprecated immediately? Then we can get rid of it in, what, 5.4?
It's not a real device yet, but it likely will not be an nvme device once a product does release with this identifier. There may be trouble with driver binding when that happens, so deprecating it here sooner than later is my preference.