On Wed, 9 Sep 2020 at 10:46, Yonggang Luo <luoyongg...@gmail.com> wrote: > > This is the compiling error: > ../ui/curses.c: In function 'curses_refresh': > ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized > in this function [-Werror=maybe-uninitialized] > 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, > maybe_keycode) > | ^~~~~~~~~~ > ../ui/curses.c:302:32: note: 'next_maybe_keycode' was declared here > 302 | enum maybe_keycode next_maybe_keycode; > | ^~~~~~~~~~~~~~~~~~ > ../ui/curses.c:256:5: error: 'maybe_keycode' may be used uninitialized in > this function [-Werror=maybe-uninitialized] > 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, > maybe_keycode) > | ^~~~~~~~~~ > ../ui/curses.c:265:24: note: 'maybe_keycode' was declared here > 265 | enum maybe_keycode maybe_keycode; > | ^~~~~~~~~~~~~ > cc1.exe: all warnings being treated as errors > > gcc version 10.2.0 (Rev1, Built by MSYS2 project) > > Signed-off-by: Yonggang Luo <luoyongg...@gmail.com> > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
I never gave this a reviewed-by tag -- can you be more careful with your tag handling, please? thanks -- PMM