On 01.09.20 14:51, Peter Lieven wrote: > in case of large continous areas that share the same allocation status > it happens that the value of s->sector_next_status is unaligned to the > cluster size or even request alignment of the source. Avoid this by > stripping down the s->sector_next_status position to cluster boundaries. > > Signed-off-by: Peter Lieven <p...@kamp.de> > --- > qemu-img.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+)
I've just noticed that with this patch, the iotest 251 fails for vhdx. Would you be OK with squashing this in? Max
diff --git a/tests/qemu-iotests/251 b/tests/qemu-iotests/251
index 7918ba3559..294773bdc1 100755
--- a/tests/qemu-iotests/251
+++ b/tests/qemu-iotests/251
@@ -46,8 +46,11 @@ if [ "$IMGOPTSSYNTAX" = "true" ]; then
# We use json:{} filenames here, so we cannot work with additional options.
_unsupported_fmt $IMGFMT
else
- # With VDI, the output is ordered differently. Just disable it.
- _unsupported_fmt vdi
+ # - With VDI, the output is ordered differently. Just disable it.
+ # - VHDX has large clusters; because qemu-img convert tries to
+ # align the requests to the cluster size, the output is ordered
+ # differently, so disable it, too.
+ _unsupported_fmt vdi vhdx
fi
signature.asc
Description: OpenPGP digital signature
