On Mon 14 Sep 2020 02:14:36 PM CEST, Max Reitz wrote: > However, I wonder what you think about “cluster_offset” in > qcow2_alloc_host_offset. It isn’t a cluster offset anymore. > Can/should we rename it?
That variable was not a cluster offset before this patch either (at least not during the first iteration of the loop). The difference is that *host_offset is always the offset of the beginning of the requested region, and cluster_offset increases with every iteration of the loop. Maybe current_offset / current_host_offset? I don't know, but I'm fine with changing it if you have a good name. Berto
