10.09.2020 19:10, Greg Kurz wrote:
On Wed, 9 Sep 2020 21:59:18 +0300
Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> wrote:
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
Reviewed-by: Greg Kurz <gr...@kaod.org>
Just one suggestion for a follow-up below...
block.c | 5 +----
block/backup-top.c | 20 ++++++++------------
[..]
@@ -253,7 +253,6 @@ void commit_start(const char *job_id, BlockDriverState *bs,
CommitBlockJob *s;
BlockDriverState *iter;
BlockDriverState *commit_top_bs = NULL;
- Error *local_err = NULL;
int ret;
... this is unrelated but while reviewing I've noticed that the ret
variable isn't really needed.
Looking at this now, I'm not quite agreed. I think that avoiding multi-line if
conditions is a good reason for additional variables, like this ret. A kind of
taste of course, so if you want you may post a patch, but I don't want do it :)
--
Best regards,
Vladimir
