Daniel P. Berrangé <berra...@redhat.com> writes: > On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> >> > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: >> > >> > Do we have a query- command handy to easily learn which snapshot names >> > are even available to attempt deletion on? If not, that's worth a >> > separate patch. >> >> Oh, I missed that one. It's the QMP equivalent to "info snapshots", and >> it is required to finish the job. Since we're at v5, I'd be okay with a >> follow-up patch, as long as it is done for 5.2. > > "query-named-block-nodes" returns BlockDeviceInfo struct, which > contains ImageInfo which contains an array of SnapshotInfo. So > we don't need any new query command.
My Acked-by stands without a new query then.