> -----Original Message----- > From: Keith Busch <[email protected]> > Sent: Tuesday, October 20, 2020 8:36 AM > To: Klaus Jensen <[email protected]> > Cc: Dmitry Fomichev <[email protected]>; Klaus Jensen > <[email protected]>; Kevin Wolf <[email protected]>; Philippe > Mathieu-Daudé <[email protected]>; Maxim Levitsky > <[email protected]>; Fam Zheng <[email protected]>; Niklas Cassel > <[email protected]>; Damien Le Moal <[email protected]>; > [email protected]; [email protected]; Alistair Francis > <[email protected]>; Matias Bjorling <[email protected]> > Subject: Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write > handlers > > On Tue, Oct 20, 2020 at 10:28:22AM +0200, Klaus Jensen wrote: > > On Oct 19 11:17, Dmitry Fomichev wrote: > > > With ZNS support in place, the majority of code in nvme_rw() has > > > become read- or write-specific. Move these parts to two separate > > > handlers, nvme_read() and nvme_write() to make the code more > > > readable and to remove multiple is_write checks that so far existed > > > in the i/o path. > > > > > > This is a refactoring patch, no change in functionality. > > > > > > > This makes a lot of sense, totally Acked, but it might be better to move > > it ahead as a preparation patch? It would make the zoned patch easier on > > the eye. > > I agree with the suggestion.
Ok, will move them to the front of the series.
