On Wed, Dec 16, 2020 at 06:59:03PM +0100, Kevin Wolf wrote: > Am 16.12.2020 um 17:21 hat Stefan Hajnoczi geschrieben: > > On Tue, Dec 15, 2020 at 05:11:06PM +0100, Kevin Wolf wrote: > > > > diff --git a/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > > b/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > > new file mode 100644 > > > > index 0000000000..caf9dad23a > > > > --- /dev/null > > > > +++ b/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > > @@ -0,0 +1,13 @@ > > > > +QEMU Storage Daemon QMP Reference Manual > > > > +======================================== > > > > + > > > > +.. > > > > + TODO: the old Texinfo manual used to note that this manual > > > > + is GPL-v2-or-later. We should make that reader-visible > > > > + both here and in our Sphinx manuals more generally. > > > > + > > > > +.. > > > > + TODO: display the QEMU version, both here and in our Sphinx manuals > > > > + more generally. > > > > + > > > > +.. qapi-doc:: storage-daemon/qapi/qapi-schema.json > > > > > > Did you intend to actually merge the TODO comments like this into master > > > or was this meant to be resolved before you send the series? > > > > Thanks for pointing this out. Both qemu-qmp-ref.rst and qemu-ga-ref.rst > > have these comments and I copied them when creating the file. I don't > > intend to try to solve that in this series. > > > > Would you like to keep the comments or should I drop them? > > Ah, I see. If the same already exists in other places, I'll just merge > it as it is. Thanks!
Great, thanks! Stefan
signature.asc
Description: PGP signature
