29.01.2021 20:30, [email protected] wrote:
Patchew URL:
https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: [email protected]
Subject: [PATCH 0/7] qcow2: compressed write cache
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
5101d00..3701c07 master -> master
- [tag update] patchew/[email protected] ->
patchew/[email protected]
* [new tag] patchew/[email protected]
-> patchew/[email protected]
Switched to a new branch 'test'
d7783a4 simplebench/bench-backup: add target-cache argument
ddf4442 simplebench/bench-backup: add --compressed option
47ee627 simplebench: bench_one(): support count=1
2b80e33 simplebench: bench_one(): add slow_limit argument
acf2fb6 block/qcow2: use compressed write cache
d96e35f block/qcow2: introduce cache for compressed writes
0d009e1 qemu/queue: add some useful QLIST_ and QTAILQ_ macros
=== OUTPUT BEGIN ===
1/7 Checking commit 0d009e16280d (qemu/queue: add some useful QLIST_ and
QTAILQ_ macros)
ERROR: spaces required around that '*' (ctx:WxV)
#25: FILE: include/qemu/queue.h:177:
+ typeof(*QLIST_FIRST(head)) *qffs_var, *qffs_next_var; \
^
WARNING: Block comments use a leading /* on a separate line
#29: FILE: include/qemu/queue.h:181:
+} while (/*CONSTCOND*/0)
ERROR: spaces required around that '*' (ctx:WxV)
#39: FILE: include/qemu/queue.h:501:
+ typeof(*QTAILQ_FIRST(head)) *qffs_var, *qffs_next_var; \
^
WARNING: Block comments use a leading /* on a separate line
#43: FILE: include/qemu/queue.h:505:
+} while (/*CONSTCOND*/0)
all false positive
--
Best regards,
Vladimir
