On Thu, Feb 04, 2021 at 05:35:31PM +0000, Peter Maydell wrote:
> On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi <[email protected]> wrote:
> >
> > The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399:
> >
> > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202'
> > into staging (2021-02-03 19:35:57 +0000)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to abe42229db7b87caa11b3c02835ebf9d384e0bd4:
> >
> > docs: fix Parallels Image "dirty bitmap" section (2021-02-04 15:17:10
> > +0000)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > v2:
> > * Rebase to resolve memory_region_init_ram_from_file() conflict due to the
> > new
> > offset argument that was added in qemu.git/master in the meantime [Peter]
> >
> > ----------------------------------------------------------------
>
> Fails to compile, clang:
>
> ../../hw/remote/mpqemu-link.c:40:29: error: suggest braces around
> initialization of subobject [-Werror,-Wmissing-braces]
> struct iovec send[2] = {0};
> ^
> {}
Stefan, should we make changes for the patch?
Please let us know.
Thanks,
Elena
>
>
> Don't use {0}, use {} -- the former may be the C standard thing,
> but the latter is the one all our supported compilers accept
> without complaint. (cf eg commit 039d4e3df0).
>
> thanks
> -- PMM
