On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
---
  docs/devel/testing.rst | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 62902cfd2d..0c18fc4571 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -246,6 +246,10 @@ given as options to the ``check`` script:
  * ``-d`` (debug) just increases the logging verbosity, showing
    for example the QMP commands and answers.
+* ``-p`` (print) allows QEMU binary stdout to be shown in the

stderr, too.

+  test console, instead of saving it into a log file in
+  ``$TEST_DIR/qemu-machine-<random_string>``.
+

It doesn’t allow this, though, it forces it. That means that tests that use the log will fail (e.g. 245)[1]. That is, I’d drop the “allows” and just state “redirect QEMU’s stdout and stderr to the test output, instead of...”.

[1] I realize that all tests will technically fail with -p, because the reference output differs, but 245 will not just fail because of that difference, but because two of its cases actually really fail. No need to make a note of this, though. It’s just that “allows” sounds a bit like qemu could choose to put some info into the test output and some into the log, when really it’s all or nothing (-p or not -p).

Max

  Test case groups
  ----------------


Reply via email to