24.05.2021 18:41, Programmingkid wrote:


On May 24, 2021, at 6:12 AM, Vladimir Sementsov-Ogievskiy 
<vsement...@virtuozzo.com> wrote:

Hi!

As reported by Programmingkid, command

qemu-system-ppc -usb -device usb-storage,drive=fat16 -drive 
file=fat:rw:fat-type=16:"<path of a host folder>",id=fat16,format=raw,if=none

crashes.

I tested it with qemu-system-x86_64 and it reproduces for me. I even
kept "<path of a host folder>" as is :).

So, here are two fixes.

Vladimir Sementsov-Ogievskiy (2):
  block/vvfat: child_vvfat_qcow: add .get_parent_aio_context, fix crash
  block/vvfat: fix vvfat_child_perm crash

include/block/block.h | 1 +
block.c               | 4 ++--
block/vvfat.c         | 8 +++-----
3 files changed, 6 insertions(+), 7 deletions(-)

--
2.29.2

I applied both of your patches to the most recent git commit today and they 
worked. I was able to share files from the host on the guest.

Thank you.

Reviewed-by: John Arbuckle <programmingk...@gmail.com>


Thanks for testing! Didn't you mean "Tested-by: "? Or if you both reviewed and 
tested, having both marks makes sense.

Hmm, also, I think "Reported-by" in first patch should be fixed to your real 
name too for consistency.

--
Best regards,
Vladimir

Reply via email to