On 8/17/21 10:21 PM, Viktor Prutyanov wrote: > Make 'qemu-img commit' work on Windows. > > Command 'commit' requires reopening backing file in RW mode. So, > add reopen prepare/commit/abort handlers and change dwShareMode > for CreateFile call in order to allow further read/write reopening. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/418 > Suggested-by: Hanna Reitz <[email protected]> > Signed-off-by: Viktor Prutyanov <[email protected]> > --- > v2: > - fix indentation in raw_reopen_prepare > - free rs if raw_reopen_prepare fails > v3: > - restore suggested-by field missed in v2 > > block/file-win32.c | 90 +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 89 insertions(+), 1 deletion(-)
LGTM, asked Helge Konetzka for testing (on the gitlab issue). Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
