04.11.2021 17:53, Emanuele Giuseppe Esposito wrote:
--- a/block/replication.c
+++ b/block/replication.c
@@ -728,9 +728,11 @@ static void replication_stop(ReplicationState *rs, bool
failover, Error **errp)
* disk, secondary disk in backup_job_completed().
*/
if (s->backup_job) {
+ aio_context_release(aio_context);
job_lock();
job_cancel_sync(&s->backup_job->job, true);
job_unlock();
+ aio_context_acquire(aio_context);
Why we need it? If we never acquire aio context under job_lock, it should be
safe to make a job-mutex critical section inside aio-context critical section.
--
Best regards,
Vladimir
