On Tue, Jan 04, 2022 at 09:54:30AM +0100, Philippe Mathieu-Daudé wrote: > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > index 462f79a1f60..c3c49176110 100644 > --- a/hw/nvme/ctrl.c > +++ b/hw/nvme/ctrl.c > @@ -1147,7 +1147,7 @@ static uint16_t nvme_tx(NvmeCtrl *n, NvmeSg *sg, > uint8_t *ptr, uint32_t len, > > if (sg->flags & NVME_SG_DMA) { > const MemTxAttrs attrs = MEMTXATTRS_UNSPECIFIED; > - uint64_t residual; > + dma_addr_t residual; > > if (dir == NVME_TX_DIRECTION_TO_DEVICE) { > residual = dma_buf_write(ptr, len, &sg->qsg, attrs);
If there's a new version: Maybe also change the return value types of dma_buf_write|read() to dma_addr_t? It'll be changed anyway in the next patch, so not a big deal. The rest patches looks good to me. Thanks. -- Peter Xu