On Mon, 10 Jan 2022 at 19:01, Akihiko Odaki <akihiko.od...@gmail.com> wrote: > Assuming the correctness of the use MAC_OS_X_VERSION_MAX_ALLOWED is > irrelevant with the nature of the identifier (constant or not), the same > problem is in ui/cocoa.m: > #ifndef MAC_OS_X_VERSION_10_13 > #define MAC_OS_X_VERSION_10_13 101300 > #endif > > /* 10.14 deprecates NSOnState and NSOffState in favor of > * NSControlStateValueOn/Off, which were introduced in 10.13. > * Define for older versions > */ > #if MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_13 > #define NSControlStateValueOn NSOnState > #define NSControlStateValueOff NSOffState > #endif
It's tempting to fix that one by just deleting the ifdeffery, since cocoa.m already doesn't compile on 10.13 (it uses NSPasteboardTypeOwner, which was only introduced in 10.14)... -- PMM
