On Mon, Jan 24, 2022 at 4:06 AM Hanna Reitz <[email protected]> wrote: > > On 21.01.22 19:47, John Snow wrote: > > > > There's no regression test, but I will trust you (and Paolo) that this > > solves the bug you were seeing. It makes sense. > > There is one in the BZ linked, but I don’t know where we’d put it into > the qemu tree... I’ve explained in v1 > (https://lists.nongnu.org/archive/html/qemu-block/2022-01/msg00024.html) > how I didn’t find a way to write a qtest for this, and so resorted to > writing boot sector code to reproduce the assertion failure. Now, we > could put that as a sample image into the iotests, but that’d just be... > wrong. (Is there a place where something like this would belong?) >
No idea. I guess it'd be more of an avacado-test level thing, but I'm not sure I know how to do it quickly. I'm worried there's lots of little things like this that'd be nice to test against, but "where do we put this" is a recurring problem. (Definitely not insisting on this being solved, and also wise enough to not want to volunteer.) > > Reviewed-by: John Snow <[email protected]> > > Tested-by: John Snow <[email protected]> > > Thanks! > > Hanna > --js
