On 1/12/22 05:43, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé <[email protected]>

fw_cfg QOM interface is required by system emulation and
qemu-storage-daemon. User-mode emulation doesn't need it.

Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
  hw/nvram/meson.build | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/nvram/meson.build b/hw/nvram/meson.build
index 202a5466e63..f5ee9f6b88c 100644
--- a/hw/nvram/meson.build
+++ b/hw/nvram/meson.build
@@ -1,5 +1,7 @@
-# QOM interfaces must be available anytime QOM is used.
-qom_ss.add(files('fw_cfg-interface.c'))
+if have_system or have_tools
+  # QOM interfaces must be available anytime QOM is used.
+  qom_ss.add(files('fw_cfg-interface.c'))
+endif

Is this intended to save the compilation of one file, if and only if this is a completely user-only build? Because if this is a normal "all targets" build, this will still be included in the user-only binaries, afaics (libqom -> qom -> common_ss).


r~

Reply via email to