If we want to provide an installable rpm in Fedora then yes; but we can leave distribution to pypi and use a bundled copy in the virtual environment that is used to run tests.
Paolo Il 5 maggio 2022 17:57:24 CEST, "Daniel P. Berrangé" <[email protected]> ha scritto: >On Thu, May 05, 2022 at 05:50:00PM +0200, Paolo Bonzini wrote: >> On 5/5/22 16:13, John Snow wrote: >> > >> > I would rather keep python/qemu/qmp as a submodule for a longer time, >> > and still go through a virtual environment that installs it together >> > with its pip dependencies. >> > >> > >> > A small headache relating fixes to both locations, but if you'd like to >> > see it to prove that the installation mechanism works in general, then >> > OK. I'm willing to deal with the pain until the next release to let us >> > go through a testing cycle. Reluctantly. Maybe. >> > >> > I'm assuming you mean as a subpackage and not a [git] submodule. If you >> > do mean git, then ... uh. That might be messy. >> >> Yeah, I meant a git submodule in qemu.git... It would also be the easiest >> way to build a subpackage in Fedora, since it would be part of the QEMU >> tarballs. > >When qemu.qmp is uploaded to PyPi, then Fedora packaging guidelines on >unbundling will expect us to create a dedicated python-qemu.qmp src.rpm, >and use that, not anything QEMU might bundle. > >With regards, >Daniel
