Re: [RFC PATCH 6/9] tests: add check-venv as a dependency of check and check-block

[Paolo Bonzini]

On 5/13/22 02:06, John Snow wrote:

  meson, create the python venv for block tests.
+.PHONY: check-block
+check-block: check-venv
+       @echo  # Without some rule, this doesn't run at all. Why?
+
+
  # Consolidated targets

.PHONY: check check-clean get-vm-images

-check:
+check: check-venv
+       @echo # ???

I think you need instead:

# The do-meson-check and do-meson-bench targets are defined in Makefile.mtest
do-meson-check do-meson-bench: check-venv

and I would even add "all" to the targets that create the virtual environment.

Paolo