Am 13.05.2022 um 10:35 hat Daniel P. Berrangé geschrieben: > On Thu, May 12, 2022 at 08:06:00PM -0400, John Snow wrote: > > RFC: This is a very early, crude attempt at switching over to an > > external Python package dependency for QMP. This series does not > > actually make the switch in and of itself, but instead just switches to > > the paradigm of using a venv in general to install the QEMU python > > packages instead of using PYTHONPATH to load them from the source tree. > > > > (By installing the package, we can process dependencies.) > > > > I'm sending it to the list so I can show you some of what's ugly so far > > and my notes on how I might make it less ugly. > > > > (1) This doesn't trigger venv creation *from* iotests, it merely prints > > a friendly error message if "make check-venv" has not been run > > first. Not the greatest. > > So if we run the sequence > > mkdir build > cd build > ../configure > make > ./tests/qemu-iotests/check 001 > > It won't work anymore, until we 'make check-venv' (or simply > 'make check') ? > > I'm somewhat inclined to say that venv should be created > unconditionally by default. ie a plain 'make' should always > everything needed to be able to invoke the tests directly.
To be honest, I'm inclined to say that we already do too much of this. When I change a source file, I usually just want qemu/qemu-img/qemu-io updated to run my manual tests. If I want to run a test case, I have no problem specifying this explicitly. This is what we had before the meson switch. But what it does now is linking lots of test binaries (that I won't run before I think that my change is finished and looking good) and taking much longer than it should take. Kevin
