On Mon, Jun 20, 2022 at 07:11:40PM +0900, Damien Le Moal wrote: > On 6/20/22 16:55, Stefan Hajnoczi wrote: > > On Mon, Jun 20, 2022 at 11:36:11AM +0800, Sam Li wrote: > >> + uint32_t nr_zones; > > > > Should this really be limited to 32-bit? For example, take 256 MB zones, > > then the max nr_zones * 256 MB is much smaller than a uint64_t capacity > > value. It seems safer to make this 64-bit, but maybe Dmitry, Hannes, or > > Damien can tell us what to do here. > > u32 is fine. We are nowhere near 4G zones :) > The max out there today is 20TB SMR drive with 128MB zones. About 150,000 > zones. Nowhere near 4G limit. Linux kernel also uses unsigned int for > number of zones everywhere.
Thanks! Stefan
signature.asc
Description: PGP signature
