Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: be0aa7ac8990c7d62f2d41a66e8c50784e7ee9ac
      
https://github.com/qemu/qemu/commit/be0aa7ac8990c7d62f2d41a66e8c50784e7ee9ac
  Author: Peter Maydell <peter.mayd...@linaro.org>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    A include/qemu/log-for-trace.h
    M include/qemu/log.h
    M scripts/tracetool/backend/log.py

  Log Message:
  -----------
  log-for-trace.h: Split out parts of log.h used by trace.h

A persistent build problem we see is where a source file
accidentally omits the #include of log.h. This slips through
local developer testing because if you configure with the
default (log) trace backend trace.h will pull in log.h for you.
Compilation fails only if some other backend is selected.

To make this error cause a compile failure regardless of
the configured trace backend, split out the parts of log.h
that trace.h requires into a new log-for-trace.h header.
Since almost all manual uses of the log.h functions will
use constants or functions which aren't in log-for-trace.h,
this will let us catch missing #include "qemu/log.h" more
consistently.

Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Message-id: 20180213140029.8308-1-peter.mayd...@linaro.org
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>


  Commit: e42860ae836dc6f768eff2d51223c47103d2dc3b
      
https://github.com/qemu/qemu/commit/e42860ae836dc6f768eff2d51223c47103d2dc3b
  Author: Stefan Hajnoczi <stefa...@redhat.com>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: fix timestamp argument type

The timestamp argument to a trace event method is documented as follows:

  The method can also take a timestamp argument before the trace event
  arguments:

    def runstate_set(self, timestamp, new_state):
  ...

  Timestamps have the uint64_t type and are in nanoseconds.

In reality methods with a timestamp argument actually receive a tuple
like (123456789,) as the timestamp argument.  This is due to a bug in
simpletrace.py.

This patch unpacks the tuple so that methods receive the correct
timestamp argument type.

Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Message-id: 20180222163901.14095-1-stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>


  Commit: 86b5aacfb972ffe0fa5fac6028e9f0bc61050dda
      
https://github.com/qemu/qemu/commit/86b5aacfb972ffe0fa5fac6028e9f0bc61050dda
  Author: Daniel P. Berrangé <berra...@redhat.com>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M scripts/simpletrace.py
    M scripts/tracetool.py
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  trace: include filename when printing parser error messages

Improves error messages from:

  ValueError: Error on line 72: need more than 1 value to unpack

To

  ValueError: Error at /home/berrange/src/virt/qemu/trace-events:72:
    need more than 1 value to unpack

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Message-id: 20180306154650.24075-1-berra...@redhat.com
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>


  Commit: 88584448502b1b1504676566b0d36991583c9ed2
      
https://github.com/qemu/qemu/commit/88584448502b1b1504676566b0d36991583c9ed2
  Author: Daniel P. Berrangé <berra...@redhat.com>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M trace-events

  Log Message:
  -----------
  trace: remove use of QEMU specific types from trace probes

Any compound structs / unions / etc, should always be declared as
'void *' pointers, since it cannot be assumed that trace backends
are able to resolve QEMU typedefs.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Message-id: 20180308155524.5082-2-berra...@redhat.com
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>


  Commit: 73ff061032efa0b260bcd1a177ac89b57a1642d3
      
https://github.com/qemu/qemu/commit/73ff061032efa0b260bcd1a177ac89b57a1642d3
  Author: Daniel P. Berrangé <berra...@redhat.com>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  trace: only permit standard C types and fixed size integer types

Some trace backends will compile code based on the declared trace
events. It should not be assumed that the backends can resolve any QEMU
specific typedefs. So trace events should restrict their argument
types to the standard C types and fixed size integer types. Any complex
pointer types can be declared as "void *" for purposes of trace events,
since nothing will be dereferencing these pointer arguments.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Message-id: 20180308155524.5082-3-berra...@redhat.com
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>


  Commit: 73988d529e2edfc0c83cb73c07f818fdfebd633c
      
https://github.com/qemu/qemu/commit/73988d529e2edfc0c83cb73c07f818fdfebd633c
  Author: Peter Maydell <peter.mayd...@linaro.org>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    A include/qemu/log-for-trace.h
    M include/qemu/log.h
    M scripts/simpletrace.py
    M scripts/tracetool.py
    M scripts/tracetool/__init__.py
    M scripts/tracetool/backend/log.py
    M trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

# gpg: Signature made Mon 12 Mar 2018 15:59:54 GMT
# gpg:                using RSA key 9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefa...@redhat.com>"
# gpg:                 aka "Stefan Hajnoczi <stefa...@gmail.com>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/tracing-pull-request:
  trace: only permit standard C types and fixed size integer types
  trace: remove use of QEMU specific types from trace probes
  trace: include filename when printing parser error messages
  simpletrace: fix timestamp argument type
  log-for-trace.h: Split out parts of log.h used by trace.h

Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>


Compare: https://github.com/qemu/qemu/compare/1396156f50dd...73988d529e2e

Reply via email to