Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: d9e4070603b9727a8c33d9aa7d2aacf5eed0c0f7 https://github.com/qemu/qemu/commit/d9e4070603b9727a8c33d9aa7d2aacf5eed0c0f7 Author: Thomas Huth <th...@redhat.com> Date: 2024-03-26 (Tue, 26 Mar 2024)
Changed paths: M tests/qemu-iotests/157 M tests/qemu-iotests/227 Log Message: ----------- tests/qemu-iotests: Test 157 and 227 require virtio-blk Tests 157 and 227 use the virtio-blk device, so we have to mark these tests accordingly to be skipped if this devices is not available (e.g. when running the tests with qemu-system-avr only). Signed-off-by: Thomas Huth <th...@redhat.com> Message-ID: <20240325154737.1305063-1-th...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Commit: 2c66de61f88dc9620a32239f7dd61524a57f66b0 https://github.com/qemu/qemu/commit/2c66de61f88dc9620a32239f7dd61524a57f66b0 Author: Kevin Wolf <kw...@redhat.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M hw/net/vhost_net.c M hw/virtio/trace-events M hw/virtio/vdpa-dev.c M hw/virtio/vhost-vdpa.c M hw/virtio/vhost.c Log Message: ----------- vdpa-dev: Fix initialisation order to restore VDUSE compatibility VDUSE requires that virtqueues are first enabled before the DRIVER_OK status flag is set; with the current API of the kernel module, it is impossible to enable the opposite order in our block export code because userspace is not notified when a virtqueue is enabled. This requirement also mathces the normal initialisation order as done by the generic vhost code in QEMU. However, commit 6c482547 accidentally changed the order for vdpa-dev and broke access to VDUSE devices with this. This changes vdpa-dev to use the normal order again and use the standard vhost callback .vhost_set_vring_enable for this. VDUSE devices can be used with vdpa-dev again after this fix. vhost_net intentionally avoided enabling the vrings for vdpa and does this manually later while it does enable them for other vhost backends. Reflect this in the vhost_net code and return early for vdpa, so that the behaviour doesn't change for this device. Cc: qemu-sta...@nongnu.org Fixes: 6c4825476a43 ('vdpa: move vhost_vdpa_set_vring_ready to the caller') Signed-off-by: Kevin Wolf <kw...@redhat.com> Message-ID: <20240315155949.86066-1-kw...@redhat.com> Reviewed-by: Eugenio Pérez <epere...@redhat.com> Reviewed-by: Stefano Garzarella <sgarz...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Commit: 3f934817c82c2f1bf1c238f8d1065a3be10a3c9e https://github.com/qemu/qemu/commit/3f934817c82c2f1bf1c238f8d1065a3be10a3c9e Author: Stefan Reiter <s.rei...@proxmox.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M block/io.c Log Message: ----------- block/io: accept NULL qiov in bdrv_pad_request Some operations, e.g. block-stream, perform reads while discarding the results (only copy-on-read matters). In this case, they will pass NULL as the target QEMUIOVector, which will however trip bdrv_pad_request, since it wants to extend its passed vector. In particular, this is the case for the blk_co_preadv() call in stream_populate(). If there is no qiov, no operation can be done with it, but the bytes and offset still need to be updated, so the subsequent aligned read will actually be aligned and not run into an assertion failure. In particular, this can happen when the request alignment of the top node is larger than the allocated part of the bottom node, in which case padding becomes necessary. For example: > ./qemu-img create /tmp/backing.qcow2 -f qcow2 64M -o cluster_size=32768 > ./qemu-io -c "write -P42 0x0 0x1" /tmp/backing.qcow2 > ./qemu-img create /tmp/top.qcow2 -f qcow2 64M -b /tmp/backing.qcow2 -F qcow2 > ./qemu-system-x86_64 --qmp stdio \ > --blockdev > qcow2,node-name=node0,file.driver=file,file.filename=/tmp/top.qcow2 \ > <<EOF > {"execute": "qmp_capabilities"} > {"execute": "blockdev-add", "arguments": { "driver": "compress", "file": > "node0", "node-name": "node1" } } > {"execute": "block-stream", "arguments": { "job-id": "stream0", "device": > "node1" } } > EOF Originally-by: Stefan Reiter <s.rei...@proxmox.com> Signed-off-by: Thomas Lamprecht <t.lampre...@proxmox.com> [FE: do update bytes and offset in any case add reproducer to commit message] Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> Message-ID: <20240322095009.346989-2-f.eb...@proxmox.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Commit: f6d38c9f6dae6fce99dcaf6ca16a1fe5b5e19c4c https://github.com/qemu/qemu/commit/f6d38c9f6dae6fce99dcaf6ca16a1fe5b5e19c4c Author: Fiona Ebner <f.eb...@proxmox.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M block/block-backend.c Log Message: ----------- block-backend: fix edge case in bdrv_next() where BDS associated to BB changes The old_bs variable in bdrv_next() is currently determined by looking at the old block backend. However, if the block graph changes before the next bdrv_next() call, it might be that the associated BDS is not the same that was referenced previously. In that case, the wrong BDS is unreferenced, leading to an assertion failure later: > bdrv_unref: Assertion `bs->refcnt > 0' failed. In particular, this can happen in the context of bdrv_flush_all(), when polling for bdrv_co_flush() in the generated co-wrapper leads to a graph change (for example with a stream block job [0]). A racy reproducer: > #!/bin/bash > rm -f /tmp/backing.qcow2 > rm -f /tmp/top.qcow2 > ./qemu-img create /tmp/backing.qcow2 -f qcow2 64M > ./qemu-io -c "write -P42 0x0 0x1" /tmp/backing.qcow2 > ./qemu-img create /tmp/top.qcow2 -f qcow2 64M -b /tmp/backing.qcow2 -F qcow2 > ./qemu-system-x86_64 --qmp stdio \ > --blockdev > qcow2,node-name=node0,file.driver=file,file.filename=/tmp/top.qcow2 \ > <<EOF > {"execute": "qmp_capabilities"} > {"execute": "block-stream", "arguments": { "job-id": "stream0", "device": > "node0" } } > {"execute": "quit"} > EOF [0]: > #0 bdrv_replace_child_tran (child=..., new_bs=..., tran=...) > #1 bdrv_replace_node_noperm (from=..., to=..., auto_skip=..., tran=..., > errp=...) > #2 bdrv_replace_node_common (from=..., to=..., auto_skip=..., > detach_subchain=..., errp=...) > #3 bdrv_drop_filter (bs=..., errp=...) > #4 bdrv_cor_filter_drop (cor_filter_bs=...) > #5 stream_prepare (job=...) > #6 job_prepare_locked (job=...) > #7 job_txn_apply_locked (fn=..., job=...) > #8 job_do_finalize_locked (job=...) > #9 job_exit (opaque=...) > #10 aio_bh_poll (ctx=...) > #11 aio_poll (ctx=..., blocking=...) > #12 bdrv_poll_co (s=...) > #13 bdrv_flush (bs=...) > #14 bdrv_flush_all () > #15 do_vm_stop (state=..., send_stop=...) > #16 vm_shutdown () Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> Message-ID: <20240322095009.346989-3-f.eb...@proxmox.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Commit: bac09b093ebbb79e6a7444c7b979c32ca5540132 https://github.com/qemu/qemu/commit/bac09b093ebbb79e6a7444c7b979c32ca5540132 Author: Fiona Ebner <f.eb...@proxmox.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M block/block-backend.c Log Message: ----------- block-backend: fix edge case in bdrv_next_cleanup() where BDS associated to BB changes Same rationale as for commit "block-backend: fix edge case in bdrv_next() where BDS associated to BB changes". The block graph might change between the bdrv_next() call and the bdrv_next_cleanup() call, so it could be that the associated BDS is not the same that was referenced previously anymore. Instead, rely on bdrv_next() to set it->bs to the BDS it referenced and unreference that one in any case. Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> Message-ID: <20240322095009.346989-4-f.eb...@proxmox.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Commit: 12d7b3bbd3333cededd3b695501d8d247239d769 https://github.com/qemu/qemu/commit/12d7b3bbd3333cededd3b695501d8d247239d769 Author: Fiona Ebner <f.eb...@proxmox.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: A tests/qemu-iotests/tests/stream-unaligned-prefetch A tests/qemu-iotests/tests/stream-unaligned-prefetch.out Log Message: ----------- iotests: add test for stream job with an unaligned prefetch read Previously, bdrv_pad_request() could not deal with a NULL qiov when a read needed to be aligned. During prefetch, a stream job will pass a NULL qiov. Add a test case to cover this scenario. By accident, also covers a previous race during shutdown, where block graph changes during iteration in bdrv_flush_all() could lead to unreferencing the wrong block driver state and an assertion failure later. Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> Message-ID: <20240322095009.346989-5-f.eb...@proxmox.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Commit: 9dab7bbb017d11b64c52239fa4e2f910a6a004f2 https://github.com/qemu/qemu/commit/9dab7bbb017d11b64c52239fa4e2f910a6a004f2 Author: Gregory Price <gregory.pr...@memverge.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M target/i386/tcg/sysemu/excp_helper.c Log Message: ----------- target/i386/tcg: Enable page walking from MMIO memory CXL emulation of interleave requires read and write hooks due to requirement for subpage granularity. The Linux kernel stack now enables using this memory as conventional memory in a separate NUMA node. If a process is deliberately forced to run from that node $ numactl --membind=1 ls the page table walk on i386 fails. Useful part of backtrace: (cpu=cpu@entry=0x555556fd9000, fmt=fmt@entry=0x555555fe3378 "cpu_io_recompile: could not find TB for pc=%p") at ../../cpu-target.c:359 (retaddr=0, addr=19595792376, attrs=..., xlat=<optimized out>, cpu=0x555556fd9000, out_offset=<synthetic pointer>) at ../../accel/tcg/cputlb.c:1339 (cpu=0x555556fd9000, full=0x7fffee0d96e0, ret_be=ret_be@entry=0, addr=19595792376, size=size@entry=8, mmu_idx=4, type=MMU_DATA_LOAD, ra=0) at ../../accel/tcg/cputlb.c:2030 (cpu=cpu@entry=0x555556fd9000, p=p@entry=0x7ffff56fddc0, mmu_idx=<optimized out>, type=type@entry=MMU_DATA_LOAD, memop=<optimized out>, ra=ra@entry=0) at ../../accel/tcg/cputlb.c:2356 (cpu=cpu@entry=0x555556fd9000, addr=addr@entry=19595792376, oi=oi@entry=52, ra=ra@entry=0, access_type=access_type@entry=MMU_DATA_LOAD) at ../../accel/tcg/cputlb.c:2439 at ../../accel/tcg/ldst_common.c.inc:301 at ../../target/i386/tcg/sysemu/excp_helper.c:173 (err=0x7ffff56fdf80, out=0x7ffff56fdf70, mmu_idx=0, access_type=MMU_INST_FETCH, addr=18446744072116178925, env=0x555556fdb7c0) at ../../target/i386/tcg/sysemu/excp_helper.c:578 (cs=0x555556fd9000, addr=18446744072116178925, size=<optimized out>, access_type=MMU_INST_FETCH, mmu_idx=0, probe=<optimized out>, retaddr=0) at ../../target/i386/tcg/sysemu/excp_helper.c:604 Avoid this by plumbing the address all the way down from x86_cpu_tlb_fill() where is available as retaddr to the actual accessors which provide it to probe_access_full() which already handles MMIO accesses. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2180 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2220 Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Suggested-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Gregory Price <gregory.pr...@memverge.com> Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> Message-ID: <20240307155304.31241-2-jonathan.came...@huawei.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: 7c7a9f578e4fb1adff7ac8d9acaaaedb87474e76 https://github.com/qemu/qemu/commit/7c7a9f578e4fb1adff7ac8d9acaaaedb87474e76 Author: Lorenz Brun <lor...@brun.one> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M hw/scsi/scsi-generic.c Log Message: ----------- hw/scsi/scsi-generic: Fix io_timeout property not applying The io_timeout property, introduced in c9b6609 (part of 6.0) is silently overwritten by the hardcoded default value of 30 seconds (DEFAULT_IO_TIMEOUT) in scsi_generic_realize because that function is being called after the properties have already been applied. The property definition already has a default value which is applied correctly when no value is explicitly set, so we can just remove the code which overrides the io_timeout completely. This has been tested by stracing SG_IO operations with the io_timeout property set and unset and now sets the timeout field in the ioctl request to the proper value. Fixes: c9b6609b69facad ("scsi: make io_timeout configurable") Signed-off-by: Lorenz Brun <lor...@brun.one> Message-ID: <20240315145831.2531695-1-lor...@brun.one> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: a158c63b3ba120f1656e4dd815d186c623fb5ef6 https://github.com/qemu/qemu/commit/a158c63b3ba120f1656e4dd815d186c623fb5ef6 Author: Yao Xingtao <yaoxt.f...@fujitsu.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M monitor/hmp-cmds-target.c Log Message: ----------- monitor/hmp-cmds-target: Append a space in error message in gpa2hva() In qemu monitor mode, when we use gpa2hva command to print the host virtual address corresponding to a guest physical address, if the gpa is not in RAM, the error message is below: (qemu) gpa2hva 0x750000000 Memory at address 0x750000000is not RAM A space is missed between '0x750000000' and 'is'. Signed-off-by: Yao Xingtao <yaoxt.f...@fujitsu.com> Fixes: e9628441df ("hmp: gpa2hva and gpa2hpa hostaddr command") Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Dr. David Alan Gilbert <d...@treblig.org> Message-ID: <20240319021610.2423844-1-ruansy.f...@fujitsu.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: e66d741467d3062e1d7d2150d2c8de0b805095d2 https://github.com/qemu/qemu/commit/e66d741467d3062e1d7d2150d2c8de0b805095d2 Author: Philippe Mathieu-Daudé <phi...@linaro.org> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M target/tricore/helper.c Log Message: ----------- target/tricore/helper: Use correct string format in cpu_tlb_fill() 'address' got converted from target_ulong to vaddr in commit 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). Use the corresponding format string to avoid casting. Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Message-ID: <20240319051413.6956-1-phi...@linaro.org> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Reviewed-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> Commit: 52405b7f69d03428950c33ebe823e2256e6a4a70 https://github.com/qemu/qemu/commit/52405b7f69d03428950c33ebe823e2256e6a4a70 Author: Philippe Mathieu-Daudé <phi...@linaro.org> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M docs/devel/clocks.rst M hw/core/clock.c M include/hw/clock.h Log Message: ----------- hw/clock: Let clock_set_mul_div() return a boolean value Let clock_set_mul_div() return a boolean value whether the clock has been updated or not, similarly to clock_set(). Return early when clock_set_mul_div() is called with same mul/div values the clock has. Acked-by: Luc Michel <l...@lmichel.fr> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Message-Id: <20240325152827.73817-2-phi...@linaro.org> Commit: 1f439706a0675c67ff45ac92b6bd95c1f41db8b3 https://github.com/qemu/qemu/commit/1f439706a0675c67ff45ac92b6bd95c1f41db8b3 Author: Philippe Mathieu-Daudé <phi...@linaro.org> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M hw/misc/stm32l4x5_rcc.c Log Message: ----------- hw/misc/stm32l4x5_rcc: Inline clock_update() in clock_mux_update() Trivial inlining in preliminary patch to make the next one easier to review. Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Message-Id: <20240325152827.73817-3-phi...@linaro.org> Commit: 32da7e207ce096f94b5d9659b0cc7f1aa9ae3ef5 https://github.com/qemu/qemu/commit/32da7e207ce096f94b5d9659b0cc7f1aa9ae3ef5 Author: Arnaud Minier <arnaud.min...@telecom-paris.fr> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M hw/misc/stm32l4x5_rcc.c Log Message: ----------- hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock The "clock_set_mul_div" function doesn't propagate the clock period to the children if it is changed (e.g. by enabling/disabling a clock multiplexer). This was overlooked during the implementation due to late changes. This commit propagates the change if the multiplier or divider changes. Fixes: ec7d83acbd ("hw/misc/stm32l4x5_rcc: Add an internal clock multiplexer object") Signed-off-by: Arnaud Minier <arnaud.min...@telecom-paris.fr> Signed-off-by: Inès Varhol <ines.var...@telecom-paris.fr> Message-ID: <20240317103918.44375-2-arnaud.min...@telecom-paris.fr> [PMD: Check clock_set_mul_div() return value] Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Message-Id: <20240325152827.73817-4-phi...@linaro.org> Commit: 1dd7754aca3b125d7697b9461730bc075c2508fe https://github.com/qemu/qemu/commit/1dd7754aca3b125d7697b9461730bc075c2508fe Author: BALATON Zoltan <bala...@eik.bme.hu> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M docs/system/ppc/amigang.rst Log Message: ----------- docs/system/ppc/amigang.rst: Fix formatting Add missing space to fix character formatting where it was missed in two places. Fixes: 623d9065b6 (docs/system/ppc: Document running Linux on AmigaNG machines) Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Message-ID: <20240324161148.4650d4e6...@zero.eik.bme.hu> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: d5866a7a4e5a4178ccab4ca19303ea09635e5fa4 https://github.com/qemu/qemu/commit/d5866a7a4e5a4178ccab4ca19303ea09635e5fa4 Author: Yao Xingtao <yaoxt.f...@fujitsu.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M contrib/plugins/execlog.c Log Message: ----------- contrib/plugins/execlog: Fix compiler warning 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is 'gpointer' {aka 'void *'}, but the type of reg->name is 'const char*'. Cast the type of reg->name to 'gpointer' to avoid this problem. compiler warning message: contrib/plugins/execlog.c:330:17: warning: ‘g_pattern_match_string’ is deprecated: Use 'g_pattern_spec_match_string' instead [-Wdeprecated-declarations] 330 | if (g_pattern_match_string(pat, rd->name) || | ^~ In file included from /usr/include/glib-2.0/glib.h:67, from contrib/plugins/execlog.c:9: /usr/include/glib-2.0/glib/gpattern.h:57:15: note: declared here 57 | gboolean g_pattern_match_string (GPatternSpec *pspec, | ^~~~~~~~~~~~~~~~~~~~~~ contrib/plugins/execlog.c:331:21: warning: ‘g_pattern_match_string’ is deprecated: Use 'g_pattern_spec_match_string' instead [-Wdeprecated-declarations] 331 | g_pattern_match_string(pat, rd_lower)) { | ^~~~~~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/glib/gpattern.h:57:15: note: declared here 57 | gboolean g_pattern_match_string (GPatternSpec *pspec, | ^~~~~~~~~~~~~~~~~~~~~~ contrib/plugins/execlog.c:339:63: warning: passing argument 2 of ‘g_ptr_array_add’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 339 | g_ptr_array_add(all_reg_names, reg->name); | ~~~^~~~~~ In file included from /usr/include/glib-2.0/glib.h:33: /usr/include/glib-2.0/glib/garray.h:198:62: note: expected ‘gpointer’ {aka ‘void *’} but argument is of type ‘const char *’ 198 | gpointer data); | ~~~~~~~~~~~~~~~~~~^~~~ Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2210 Signed-off-by: Yao Xingtao <yaoxt.f...@fujitsu.com> Message-ID: <20240326015257.21516-1-yaoxt.f...@fujitsu.com> Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: 5c5d00df67a33d3931c35d566329f3d90013732b https://github.com/qemu/qemu/commit/5c5d00df67a33d3931c35d566329f3d90013732b Author: Igor Mammedov <imamm...@redhat.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M hw/smbios/smbios_legacy_stub.c Log Message: ----------- hw/smbios: add stub for smbios_get_table_legacy() QEMU build fails with hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' when it's built with only 'microvm' enabled i.e. with config patch +++ b/configs/devices/i386-softmmu/default.mak @@ -26,7 +26,7 @@ # Boards: # -CONFIG_ISAPC=y -CONFIG_I440FX=y -CONFIG_Q35=y +CONFIG_ISAPC=n +CONFIG_I440FX=n +CONFIG_Q35=n It happens because I've fogotten/lost smbios_get_table_legacy() stub. Fix it by adding missing stub as Philippe suggested. Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine" Reported-by: Michael Tokarev <m...@tls.msk.ru> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Signed-off-by: Igor Mammedov <imamm...@redhat.com> Message-ID: <20240326122630.85989-1-imamm...@redhat.com> Tested-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: d2ee0420a394bb0affb06659bdb5d706af24157b https://github.com/qemu/qemu/commit/d2ee0420a394bb0affb06659bdb5d706af24157b Author: Akihiko Odaki <akihiko.od...@daynix.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M ui/cocoa.m Log Message: ----------- ui/cocoa: Fix aspect ratio [NSWindow setContentAspectRatio:] does not trigger window resize itself, so the wrong aspect ratio will persist if nothing resizes the window. Call [NSWindow setContentSize:] in such a case. Fixes: 91aa508d0274 ("ui/cocoa: Let the platform toggle fullscreen") Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Message-ID: <20240323-fixes-v2-1-18651a2b0...@daynix.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: f69a6f04133df61e2ab23553496a070f27f5b732 https://github.com/qemu/qemu/commit/f69a6f04133df61e2ab23553496a070f27f5b732 Author: Akihiko Odaki <akihiko.od...@daynix.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M ui/cocoa.m Log Message: ----------- ui/cocoa: Resize window after toggling zoom-to-fit Resize the window so that the content will fit without zooming. Fixes: 91aa508d0274 ("ui/cocoa: Let the platform toggle fullscreen") Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Message-ID: <20240323-fixes-v2-2-18651a2b0...@daynix.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: ccebb9ae352eea63cb1491cb829e4cd0f7576f1c https://github.com/qemu/qemu/commit/ccebb9ae352eea63cb1491cb829e4cd0f7576f1c Author: Akihiko Odaki <akihiko.od...@daynix.com> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M ui/cocoa.m Log Message: ----------- ui/cocoa: Use NSTrackingInVisibleRect I observed [NSTrackingArea rect] becomes de-synchronized with the view frame with some unknown condition, and fails to track mouse movement on some area of the view. Specify NSTrackingInVisibleRect option to let Cocoa automatically update NSTrackingArea, which also saves code for synchronization. Fixes: 91aa508d0274 ("ui/cocoa: Let the platform toggle fullscreen") Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Message-ID: <20240323-fixes-v2-3-18651a2b0...@daynix.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Commit: 5107022a616247216a7f7338bd7c62b4399d89eb https://github.com/qemu/qemu/commit/5107022a616247216a7f7338bd7c62b4399d89eb Author: Peter Maydell <peter.mayd...@linaro.org> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M block/block-backend.c M block/io.c M hw/net/vhost_net.c M hw/virtio/trace-events M hw/virtio/vdpa-dev.c M hw/virtio/vhost-vdpa.c M hw/virtio/vhost.c M tests/qemu-iotests/157 M tests/qemu-iotests/227 A tests/qemu-iotests/tests/stream-unaligned-prefetch A tests/qemu-iotests/tests/stream-unaligned-prefetch.out Log Message: ----------- Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging Block layer patches - Fix crash with unaligned prefetch requests (e.g. in stream jobs) - vdpa-dev: Fix initialisation order to restore VDUSE compatibility - iotests fixes # -----BEGIN PGP SIGNATURE----- # # iQJFBAABCAAvFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmYCzGQRHGt3b2xmQHJl # ZGhhdC5jb20ACgkQfwmycsiPL9YYtg//XCFC4ANO1wVw6mqByvbPEi4rG9dYiTcz # WCgS5QOVx8YMsxvyU7xg7vqT3V+7888UFx/cNC58Z5sY3TmohLus/a3Udap3ywpY # RM+Lg8qwPEyFrmATyoU41sms7q8a8V7pwPm4nHXSP7O3npS/7hRMoET4ZFLJrVUk # 72oNCHHpLeB8nnEXMvDXfMXmkHv9HthygKXlQBxX/WnjQQZObvfLsrUzk+gqUmzy # hF9ojN5jrorydI/9lbkHaFkLc6+qOVxQRqrRjjPeKt/SuqJjAhQko0QU1jWjzcm9 # 5W7hQQluVB6B7Eol/ujOzSp6wxabxT/HRq2kwLwuWW6qpNNKIECCxrUyFR4WWEt9 # TI3DDsniq/bbd+CBtL1t68PhN9S7gGorA8UPfwfgp75N3BmEPhe10BEmazpjvLCC # zTmJYgpvDOJdwhM3loeli/2CA9l4xF0jTQWfry1vaaddC4wQKmK+mJaDhCvns/RL # MPCMaZ0kuGKdFSAIqshbffEaTdOk5liuQ5l45AtUyXkZh+mcR8tjmb59RfnNCZRc # 2N8MvDF03RyUVplD3fsnapiTc+Yfzkdxc93dUGybfolvPecp+xrgQojrTyDOhCTY # ZQXjgEPNkkhMukcnRWPrG2BzQxXKeUODTFetUTjpsvGCt2RttW4EuAP000JMd7Tl # DziVCvmn6c0= # =OIUm # -----END PGP SIGNATURE----- # gpg: Signature made Tue 26 Mar 2024 13:23:48 GMT # gpg: using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6 # gpg: issuer "kw...@redhat.com" # gpg: Good signature from "Kevin Wolf <kw...@redhat.com>" [full] # Primary key fingerprint: DC3D EB15 9A9A F95D 3D74 56FE 7F09 B272 C88F 2FD6 * tag 'for-upstream' of https://repo.or.cz/qemu/kevin: iotests: add test for stream job with an unaligned prefetch read block-backend: fix edge case in bdrv_next_cleanup() where BDS associated to BB changes block-backend: fix edge case in bdrv_next() where BDS associated to BB changes block/io: accept NULL qiov in bdrv_pad_request vdpa-dev: Fix initialisation order to restore VDUSE compatibility tests/qemu-iotests: Test 157 and 227 require virtio-blk Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Commit: 38a23eb35c4799d6cad88f81a5556f5d424b3a07 https://github.com/qemu/qemu/commit/38a23eb35c4799d6cad88f81a5556f5d424b3a07 Author: Peter Maydell <peter.mayd...@linaro.org> Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M contrib/plugins/execlog.c M docs/devel/clocks.rst M docs/system/ppc/amigang.rst M hw/core/clock.c M hw/misc/stm32l4x5_rcc.c M hw/scsi/scsi-generic.c M hw/smbios/smbios_legacy_stub.c M include/hw/clock.h M monitor/hmp-cmds-target.c M target/i386/tcg/sysemu/excp_helper.c M target/tricore/helper.c M ui/cocoa.m Log Message: ----------- Merge tag 'hw-misc-20240326' of https://github.com/philmd/qemu into staging Misc HW patch queue [hw] - Do not silently overwrite 'io_timeout' property in scsi-generic (Lorenz) - Propagate period when enabling a clock in stm32l4x5 mux (Arnaud, Phil) - Add missing smbios_get_table_legacy() stub (Igor) - Append a space in gpa2hva() HMP error message (Yao) - Fix compiler warning in 'execlog' plugin (Yao) [target] - i386: Enable page walking from MMIO memory (Gregory, Jonathan) - tricore: Use correct string format in cpu_tlb_fill (Phil) [docs] - Fix formatting in amigang.rst (Zoltan) [ui] - Fix cocoa regression in platform fullscreen toggling (Akihiko) # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEE+qvnXhKRciHc/Wuy4+MsLN6twN4FAmYC7QoACgkQ4+MsLN6t # wN4WIw//cLw1caDa8ki3htGWGVI2P/QFdsvId7ah4Iul7znf6NWUORDBjvIvLpaF # sesPF7BRQ/qJFT5ttB8DsKc1IHw3IASAGL/NK3i7v9GkRiBJNJvQRO2rVfNmXvN8 # ++AZ/J+Y1OZ4Y1hcxXGUVIpwKzndR5Oz9zNXQ+C0CQqYljwxC3huB3m6C7vKOgeq # SNKVw/hrTBYLzyvooKqLb6Xual2+olSwc2/BwqUOOCP6Y1HmgQeWy5ckJqsuVS2T # 5q5VtkduBCsUhgmflsLF3LCKrNTQUw+jOAGH2gyRvXMjmvwCmNy5xo8eOD0iTwXb # +Ffp/kfqm2N1QwNWcBi39+BU+Plti03mnL7C9jNzaEBaQ9Q7wMNqASN0daHSk3vh # 4Vw/FsaUJAohInKYghCgO0fUVpeLis+8p5lDD7QwAL9tiYk7/tgrbtyNLb+m/3P9 # pPNGt9Fnijg+/zDDfjVYwtDMRbL0df7SqTjhJW3TIQ+d83tmoVuCDmBysEXywzSt # 5e4yyjDf8q1C23yipK9I84wuvWjfIDYIPSUzCKaZYf4xbdx7GyNaOoOqWZYpordD # ua/4hRuQ4AcDuCe3XBKsmAex6wpYodjnfEi5Y5uV8vyPfeiVQodY/07pok/NZjEL # tUNy3EkQFqXxT1ctT7FhN2eh6WjSo0SJFtIjVDarJ0mUkS4VXgM= # =ccz/ # -----END PGP SIGNATURE----- # gpg: Signature made Tue 26 Mar 2024 15:43:06 GMT # gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE # gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4...@amsat.org>" [full] # Primary key fingerprint: FAAB E75E 1291 7221 DCFD 6BB2 E3E3 2C2C DEAD C0DE * tag 'hw-misc-20240326' of https://github.com/philmd/qemu: ui/cocoa: Use NSTrackingInVisibleRect ui/cocoa: Resize window after toggling zoom-to-fit ui/cocoa: Fix aspect ratio hw/smbios: add stub for smbios_get_table_legacy() contrib/plugins/execlog: Fix compiler warning docs/system/ppc/amigang.rst: Fix formatting hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock hw/misc/stm32l4x5_rcc: Inline clock_update() in clock_mux_update() hw/clock: Let clock_set_mul_div() return a boolean value target/tricore/helper: Use correct string format in cpu_tlb_fill() monitor/hmp-cmds-target: Append a space in error message in gpa2hva() hw/scsi/scsi-generic: Fix io_timeout property not applying target/i386/tcg: Enable page walking from MMIO memory Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Compare: https://github.com/qemu/qemu/compare/096ae430a7b5...38a23eb35c47 To unsubscribe from these emails, change your notification settings at https://github.com/qemu/qemu/settings/notifications