Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 62663f08a75dbbddb745c80a00b09e298ede641a https://github.com/qemu/qemu/commit/62663f08a75dbbddb745c80a00b09e298ede641a Author: Will Gyda <vilhelmg...@gmail.com> Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths: M migration/ram.c Log Message: ----------- migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro Signed-off-by: Will Gyda <vilhelmg...@gmail.com> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: d4a17b8f1da567b274f7c7e4846496c564c860c4 https://github.com/qemu/qemu/commit/d4a17b8f1da567b274f7c7e4846496c564c860c4 Author: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M migration/migration.c M migration/trace-events Log Message: ----------- migration: move trace-point from migrate_fd_error to migrate_set_error Cover more cases by trace-point. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Reviewed-by: Fabiano Rosas <faro...@suse.de> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: 246f54e0ccc288239fae78ec9e401ba070667b0b https://github.com/qemu/qemu/commit/246f54e0ccc288239fae78ec9e401ba070667b0b Author: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M migration/migration.c Log Message: ----------- migration: process_incoming_migration_co(): complete cleanup on failure Make call to migration_incoming_state_destroy(), instead of doing only partial of it. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Reviewed-by: Fabiano Rosas <faro...@suse.de> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: 30116e9079e3f395ef186960d986c7d073d7eb8a https://github.com/qemu/qemu/commit/30116e9079e3f395ef186960d986c7d073d7eb8a Author: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M migration/migration.c Log Message: ----------- migration: process_incoming_migration_co(): fix reporting s->error It's bad idea to leave critical section with error object freed, but s->error still set, this theoretically may lead to use-after-free crash. Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Reviewed-by: Fabiano Rosas <faro...@suse.de> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: f84eaa9ffdcf00a81922fc1380870775a60792bf https://github.com/qemu/qemu/commit/f84eaa9ffdcf00a81922fc1380870775a60792bf Author: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M migration/migration.c Log Message: ----------- migration: process_incoming_migration_co(): rework error reporting Unify error reporting in the function. This simplifies the following commit, which will not-exit-on-error behavior variant to the function. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: dbea1c89dad37a6ab96befd017d33edaa50ded0a https://github.com/qemu/qemu/commit/dbea1c89dad37a6ab96befd017d33edaa50ded0a Author: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M migration/migration-hmp-cmds.c M migration/migration.c M migration/migration.h M qapi/migration.json M system/vl.c Log Message: ----------- qapi: introduce exit-on-error parameter for migrate-incoming Now we do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's provide a possibility for QMP-based orchestrators to get an error like with outgoing migration. For hmp_migrate_incoming(), let's enable the new behavior: HMP is not and ABI, it's mostly intended to use by developer and it makes sense not to stop the process. For x-exit-preconfig, let's keep the old behavior: - it's called from init(), so here we want to keep current behavior by default - it does exit on error by itself as well So, if we want to change the behavior of x-exit-preconfig, it should be another patch. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Acked-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Fabiano Rosas <faro...@suse.de> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: f7b1cd3c2ebbc102b8edfacd5c5cd10c04dc887d https://github.com/qemu/qemu/commit/f7b1cd3c2ebbc102b8edfacd5c5cd10c04dc887d Author: Fabiano Rosas <faro...@suse.de> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M docs/about/deprecated.rst M docs/about/removed-features.rst M migration/migration-hmp-cmds.c M migration/migration.c M qapi/migration.json Log Message: ----------- migration: Remove 'skipped' field from MigrationStats The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: 61c4e39f7301f67408024346ad3eb5335aec0311 https://github.com/qemu/qemu/commit/61c4e39f7301f67408024346ad3eb5335aec0311 Author: Fabiano Rosas <faro...@suse.de> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M docs/about/deprecated.rst M docs/about/removed-features.rst M hmp-commands.hx M migration/block.c M migration/migration-hmp-cmds.c M migration/migration.c M migration/options.c M migration/options.h M qapi/migration.json Log Message: ----------- migration: Remove 'inc' option from migrate command The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Reviewed-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: 18d154f57583dd06f0ce3e69e4952044490b2bc4 https://github.com/qemu/qemu/commit/18d154f57583dd06f0ce3e69e4952044490b2bc4 Author: Fabiano Rosas <faro...@suse.de> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M .gitlab-ci.d/buildtest.yml M docs/about/deprecated.rst M docs/about/removed-features.rst M hmp-commands.hx M migration/migration-hmp-cmds.c M migration/migration.c M migration/migration.h M migration/options.c M migration/options.h M qapi/migration.json R tests/qemu-iotests/183 R tests/qemu-iotests/183.out M tests/qemu-iotests/common.filter Log Message: ----------- migration: Remove 'blk/-b' option from migrate commands The block migration is considered obsolete and has been deprecated in 8.2. Remove the migrate command option that enables it. This only affects the QMP and HMP commands, the feature can still be accessed by setting the migration 'block' capability. The whole feature will be removed in a future patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Reviewed-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: eef0bae3a75fa33921ac859f70fd154310915ad4 https://github.com/qemu/qemu/commit/eef0bae3a75fa33921ac859f70fd154310915ad4 Author: Fabiano Rosas <faro...@suse.de> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M MAINTAINERS M docs/about/deprecated.rst M docs/about/removed-features.rst M docs/devel/migration/main.rst M include/migration/misc.h M meson.build M meson_options.txt R migration/block.c R migration/block.h M migration/colo.c M migration/meson.build M migration/migration-hmp-cmds.c M migration/migration.c M migration/options.c M migration/options.h M migration/ram.c M migration/savevm.c M qapi/migration.json M scripts/meson-buildoptions.sh Log Message: ----------- migration: Remove block migration The block migration has been considered obsolete since QEMU 8.2 in favor of the more flexible storage migration provided by the blockdev-mirror driver. Two releases have passed so now it's time to remove it. Deprecation commit 66db46ca83 ("migration: Deprecate block migration"). Reviewed-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: 0222111a22b2d3e08c62edb6b18bd8bdea4b64d5 https://github.com/qemu/qemu/commit/0222111a22b2d3e08c62edb6b18bd8bdea4b64d5 Author: Fabiano Rosas <faro...@suse.de> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M docs/about/deprecated.rst M docs/about/removed-features.rst M hw/core/machine.c M migration/meson.build M migration/migration-hmp-cmds.c M migration/migration.c M migration/migration.h M migration/options.c M migration/options.h M migration/qemu-file.c M migration/qemu-file.h R migration/ram-compress.c R migration/ram-compress.h M migration/ram.c M qapi/migration.json M tests/qtest/migration-test.c Log Message: ----------- migration: Remove non-multifd compression The 'compress' migration capability enables the old compression code which has shown issues over the years and is thought to be less stable and tested than the more recent multifd-based compression. The old compression code has been deprecated in 8.2 and now is time to remove it. Deprecation commit 864128df46 ("migration: Deprecate old compression method"). Acked-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: c55deb860ce54cc5ecebb5f170fea85969cb6aad https://github.com/qemu/qemu/commit/c55deb860ce54cc5ecebb5f170fea85969cb6aad Author: Fabiano Rosas <faro...@suse.de> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M docs/about/deprecated.rst M migration/fd.c Log Message: ----------- migration: Deprecate fd: for file migration The fd: URI can currently trigger two different types of migration, a TCP migration using sockets and a file migration using a plain file. This is in conflict with the recently introduced (8.2) QMP migrate API that takes structured data as JSON-like format. We cannot keep the same backend for both types of migration because with the new API the code is more tightly coupled to the type of transport. This means a TCP migration must use the 'socket' transport and a file migration must use the 'file' transport. If we keep allowing fd: when using a file, this creates an issue when the user converts the old-style (fd:) to the new style ("transport": "socket") invocation because the file descriptor in question has previously been allowed to be either a plain file or a socket. To avoid creating too much confusion, we can simply deprecate the fd: + file usage, which is thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Reviewed-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: db8cb7b6e73690233bc7c6abbb90979af3a18143 https://github.com/qemu/qemu/commit/db8cb7b6e73690233bc7c6abbb90979af3a18143 Author: Peter Xu <pet...@redhat.com> Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M hmp-commands.hx Log Message: ----------- hmp/migration: Fix "migrate" command's documentation Peter missed the Sphinx HMP document for the "resume/-r" flag in commit 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. When at it, slightly cleanup the lines around: - Move "detach/-d" to a separate section rather than appending it at the end of the command description. Add a hint for how to query the migration results in detached mode. - Add "postcopy" keyword to "resume/-r" help messages, as it only applies to postcopy. Cc: Dr. David Alan Gilbert <d...@treblig.org> Cc: Fabiano Rosas <faro...@suse.de> Fixes: 7a4da28b26 ("qmp: hmp: add migrate "resume" option") Reported-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Peter Xu <pet...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> Commit: f532cf013133320045b8588c2f62fc847902fd18 https://github.com/qemu/qemu/commit/f532cf013133320045b8588c2f62fc847902fd18 Author: Bibo Mao <maob...@loongson.cn> Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M hw/loongarch/virt.c Log Message: ----------- hw/loongarch: Refine default numa id calculation With numa_test test case, there is subcase named test_def_cpu_split(), there are 8 sockets and 2 numa nodes. Here is command line: "-machine smp.cpus=8,smp.sockets=8 -numa node,memdev=ram -numa node" The required result is: node 0 cpus: 0 2 4 6 node 1 cpus: 1 3 5 7 Test case numa_test fails on LoongArch, since the actual result is: node 0 cpus: 0 1 2 3 node 1 cpus: 4 5 6 7 It will be better if all the cpus in one socket share the same numa node. Here socket id is used to calculate numa id in function virt_get_default_cpu_node_id(). Signed-off-by: Bibo Mao <maob...@loongson.cn> Reviewed-by: Song Gao <gaos...@loongson.cn> Message-Id: <20240319022606.2994565-1-maob...@loongson.cn> Signed-off-by: Song Gao <gaos...@loongson.cn> Commit: 6f703a48410db455057cc90c170e908de83b23fc https://github.com/qemu/qemu/commit/6f703a48410db455057cc90c170e908de83b23fc Author: Bibo Mao <maob...@loongson.cn> Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M target/loongarch/cpu.c M target/loongarch/cpu.h M target/loongarch/cpu_helper.c M target/loongarch/machine.c Log Message: ----------- target/loongarch: Add TCG macro in structure CPUArchState In structure CPUArchState some struct elements are only used in TCG mode, and it is not used in KVM mode. Macro CONFIG_TCG is added to make it simpiler in KVM mode, also there is the same modification in c code when these structure elements are used. When VM runs in KVM mode, TLB entries are not used and do not need migrate. It is only useful when it runs in TCG mode. Signed-off-by: Bibo Mao <maob...@loongson.cn> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Message-Id: <20240506011912.2108842-1-maob...@loongson.cn> Signed-off-by: Song Gao <gaos...@loongson.cn> Commit: 5872966db7abaa7f8753541b7a9f242df9752b50 https://github.com/qemu/qemu/commit/5872966db7abaa7f8753541b7a9f242df9752b50 Author: Bibo Mao <maob...@loongson.cn> Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M target/loongarch/kvm/kvm.c Log Message: ----------- target/loongarch: Put cpucfg operation before CSR register On Loongarch, cpucfg is register for cpu feature, some other registers depend on cpucfg feature such as perf CSR registers. Here put cpucfg read/write operations before CSR register, so that KVM knows how many perf CSR registers are valid from pre-set cpucfg feature information. Signed-off-by: Bibo Mao <maob...@loongson.cn> Reviewed-by: Song Gao <gaos...@loongson.cn> Message-Id: <20240428031651.1354587-1-maob...@loongson.cn> Signed-off-by: Song Gao <gaos...@loongson.cn> Commit: a016dd50052924d0de255e31b9b9f6a188ebc08b https://github.com/qemu/qemu/commit/a016dd50052924d0de255e31b9b9f6a188ebc08b Author: Richard Henderson <richard.hender...@linaro.org> Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M .gitlab-ci.d/buildtest.yml M MAINTAINERS M docs/about/deprecated.rst M docs/about/removed-features.rst M docs/devel/migration/main.rst M hmp-commands.hx M hw/core/machine.c M include/migration/misc.h M meson.build M meson_options.txt R migration/block.c R migration/block.h M migration/colo.c M migration/fd.c M migration/meson.build M migration/migration-hmp-cmds.c M migration/migration.c M migration/migration.h M migration/options.c M migration/options.h M migration/qemu-file.c M migration/qemu-file.h R migration/ram-compress.c R migration/ram-compress.h M migration/ram.c M migration/savevm.c M migration/trace-events M qapi/migration.json M scripts/meson-buildoptions.sh M system/vl.c R tests/qemu-iotests/183 R tests/qemu-iotests/183.out M tests/qemu-iotests/common.filter M tests/qtest/migration-test.c Log Message: ----------- Merge tag 'migration-20240508-pull-request' of https://gitlab.com/farosas/qemu into staging Migration pull request - Will's WITH_QEMU_LOCK_GUARD cleanup - Vladimir's new exit-on-error parameter - Fabiano's removals and deprecations series (block migration and non-multifd compression removed) - Peter's documentation fix for HMP migrate command v2: - updated Peter's documentation fix. # -----BEGIN PGP SIGNATURE----- # # iQJEBAABCAAuFiEEqhtIsKIjJqWkw2TPx5jcdBvsMZ0FAmY7934QHGZhcm9zYXNA # c3VzZS5kZQAKCRDHmNx0G+wxnXynEADHjRa7HqwuYPhft3wGgLiFbCyQNFpNrjM9 # prQSiLlYt9gRlE4c9ZavCxR28xtOrK2oFhCnLMXaIEkct6JuylfiwCPwPuxNQP9+ # EZirECf1yKkyt+RV/LfIx3R/prJgoH5XWhpna+WIBFFo2qSorHTAzjb5dKYZDjkB # EjfN8R9goVH6aCPd4SyiCUUNxuR6/0si9AxfhUgUvUXyLZmE1ztZEoWI02FCYzVj # kKDdVK2+Z1Rlv88tyY4/E6z4pwYLWx5EiXSFv0NXIpTdyO3dM+jeAHxcN7KmQ1+5 # GvX0n+mFYOzRIbRfAnhSZbkez/nuPcbJ76phzSYDs8f/7YtOpuOFKFw7yuGrl5N5 # ZqXo5MOOGliF2wozTjacsOrUhB+MbSb0iA71T7aAdBC2s4H9+XIWfoN/OZfsBhAW # r2i1gSytVLQqsip7A0CFF+DqeSse9QHHlH8vfb8NUn1Tp0o2QfsX+/7LHlvl/2eJ # EP/zmjD6c/8vjB3fTKZr52h2lEO/36xmX+OtZpep3EBvvl1BY1LP4nBNOW1vQM/b # fzcq+agaikwS5gI2QSOC9HJ3aX6q416+wZEm3rQ8XRGSPDFfLPKM/GPPfWdj6ngb # +e3EZPrs+3dOeH1kly5xVMGXGUof+VVBmVwdv4C+XNMM8fRZOxoqd0SD8dz/vOC7 # nSGztXUPqw== # =5T+K # -----END PGP SIGNATURE----- # gpg: Signature made Thu 09 May 2024 12:06:54 AM CEST # gpg: using RSA key AA1B48B0A22326A5A4C364CFC798DC741BEC319D # gpg: issuer "faro...@suse.de" # gpg: Good signature from "Fabiano Rosas <faro...@suse.de>" [unknown] # gpg: aka "Fabiano Almeida Rosas <fabiano.ro...@suse.com>" [unknown] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: AA1B 48B0 A223 26A5 A4C3 64CF C798 DC74 1BEC 319D * tag 'migration-20240508-pull-request' of https://gitlab.com/farosas/qemu: hmp/migration: Fix "migrate" command's documentation migration: Deprecate fd: for file migration migration: Remove non-multifd compression migration: Remove block migration migration: Remove 'blk/-b' option from migrate commands migration: Remove 'inc' option from migrate command migration: Remove 'skipped' field from MigrationStats qapi: introduce exit-on-error parameter for migrate-incoming migration: process_incoming_migration_co(): rework error reporting migration: process_incoming_migration_co(): fix reporting s->error migration: process_incoming_migration_co(): complete cleanup on failure migration: move trace-point from migrate_fd_error to migrate_set_error migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro Signed-off-by: Richard Henderson <richard.hender...@linaro.org> Commit: 937e2cb759589105fb73f796c11fe7ae80b0d66e https://github.com/qemu/qemu/commit/937e2cb759589105fb73f796c11fe7ae80b0d66e Author: Richard Henderson <richard.hender...@linaro.org> Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M hw/loongarch/virt.c M target/loongarch/cpu.c M target/loongarch/cpu.h M target/loongarch/cpu_helper.c M target/loongarch/kvm/kvm.c M target/loongarch/machine.c Log Message: ----------- Merge tag 'pull-loongarch-20240509' of https://gitlab.com/gaosong/qemu into staging pull-loongarch-20240509 # -----BEGIN PGP SIGNATURE----- # # iLMEAAEKAB0WIQS4/x2g0v3LLaCcbCxAov/yOSY+3wUCZjyDAgAKCRBAov/yOSY+ # 33cfA/4jE0x+eLAT161caSwM3wBOfZRClfUhXdkxLP6GvWbACVQ8l0rEZiw2PuI8 # DFReU2gqs7wAfYKt7Yy62xXlCw1B3aSUzE45gS2TGIP1GqKBwigvpW4i1SgiOoMX # 4TA+GG16KgR9zaxO48bjjyJ1epc7S3SxdAL09p2U08D9EdSwCA== # =RLFu # -----END PGP SIGNATURE----- # gpg: Signature made Thu 09 May 2024 10:02:10 AM CEST # gpg: using RSA key B8FF1DA0D2FDCB2DA09C6C2C40A2FFF239263EDF # gpg: Good signature from "Song Gao <m17746591...@163.com>" [unknown] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: B8FF 1DA0 D2FD CB2D A09C 6C2C 40A2 FFF2 3926 3EDF * tag 'pull-loongarch-20240509' of https://gitlab.com/gaosong/qemu: target/loongarch: Put cpucfg operation before CSR register target/loongarch: Add TCG macro in structure CPUArchState hw/loongarch: Refine default numa id calculation Signed-off-by: Richard Henderson <richard.hender...@linaro.org> Compare: https://github.com/qemu/qemu/compare/36fa7c686e9e...937e2cb75958 To unsubscribe from these emails, change your notification settings at https://github.com/qemu/qemu/settings/notifications