On 22/05/2025 21:16, Peter Xu wrote: > I followed up with Dave's idea, but then added all entries into it, below. > > Status: postcopy-active > Time (ms): total=40504, setup=14, down=145 > RAM info: > Throughput (Mbps): 6102.65 > Sizes (KiB): pagesize=4, total=16777992 > Transfers (KiB): transferred=37673019, remain=2136404 > Channels (KiB): precopy=3, multifd=26108780, postcopy=11563855 > Page Types: normal=9394288, zero=600672 > Page Rates (pps): transfer_rate=185875, dirty_rate=278378
Regarding the "transfer_rate" and "dirty_rate" fields: Would it be clearer to drop the "_rate" suffix since the category header "Page Rates (pps)" already implies they are rate metrics? > Others: dirty_syncs=3, postcopy_req=4078 > > Logically I should have moved "Throughput" out, because that should also > include all other things (non-ram iterators, device states). But currently > it's an entry under info->ram.. so I kept it there. > > It also has the "total" in "Sizes" to make the next line shorter > (meanwhile, "total" is also a constant size like "psize"), the hope is it's > still close enough to read when reading "Transfers" on the next line. > > I also provided further indents to "Channels" and "Page Types" because they > should be taken as sub-class of "Transfer". > > How is this? Since we're at it, I can send a follow up patch after we > reach a consensus (I may also include that in another series where I'll > further add things into HMP; I'm looking at making blocktime to report page > latencies too). Your revised layout aligns well with my preferences. Acked. Thanks
