On Tue, May 20, 2025 at 08:15:20PM +0000, Wei Liu wrote: > On Tue, May 20, 2025 at 01:30:04PM +0200, Magnus Kulke wrote: > > Implement initial interrupt handling logic in the MSHV backend. This > > includes management of MSI and un/registering of irqfd mechanisms. > > > > Signed-off-by: Magnus Kulke <magnusku...@linux.microsoft.com> > > --- > [...] > > +int mshv_request_interrupt(int vm_fd, uint32_t interrupt_type, uint32_t > > vector, > > + uint32_t vp_index, bool logical_dest_mode, > > + bool level_triggered) > > +{ > > + int ret; > > + > > + if (vector == 0) { > > + /* TODO: why do we receive this? */ > > You must have seen this in real life, right? We need to convince > ourselves why this is okay. > > Thanks, > Wei. >
I haven't seen this in real use, I spotted it in the mshvc library and wondered why we have this clause at this point. We can log a warning if that occurs.