On Tue, May 20, 2025 at 10:38:28PM +0000, Wei Liu wrote: > On Tue, May 20, 2025 at 01:30:15PM +0200, Magnus Kulke wrote: > > + init_emu(&mshv_x86_emul_ops); > > If I'm not mistaken, the name mshv_init_cpu_logic suggests this function > is called every time a CPU is initialized. There is no need to > repeatedly initialize the emulator. > > The code snippet should be moved to either the initialization function > of the accelerator or the initialization function of the VM object.
It's called as part of the accelerator initialization, but it's a misnomer, I agree. We'll see whether we require the guards, so this is is really just an mmio emu init.
