On 5/30/25 6:56 PM, Michael Tokarev wrote: > On 30.05.2025 09:39, Weifeng Liu wrote: >> On Thu, 2025-05-29 at 10:23 +0300, Michael Tokarev wrote: > >>>> PATCH 3 - 5 fix bugs in mouse position calculation due to not >>>> handling >>>> scale properly, for both gtk and sdl. >>>> >>>> PATCH 6 align scale update logic in gtk-egl with other >>>> implementations. >>>> >>>> PATCH 7 fix an issue that gtk window might keep enlarging/shrinking >>>> because >>>> ui info propagating to guest not considering scale. >>>> >>>> PATCH 8 and 9 align fixed-scale mode behavior in gtk-gl-area and >>>> gtk-egl with >>>> other implementations by adding appropriate padding to the window >>>> to preserve >>>> the scale. >>> ... >>>> Weifeng Liu (9): >>>> ui/gtk: Document scale and coordinate handling >>>> ui/gtk: Use consistent naming for variables in different >>>> coordinates >>>> gtk/ui: Introduce helper gd_update_scale >>>> ui/gtk: Update scales in fixed-scale mode when rendering GL area >>>> ui/sdl: Consider scaling in mouse event handling >>>> ui/gtk: Don't update scale in fixed scale mode in gtk-egl.c >>>> ui/gtk: Consider scaling when propagating ui info >>>> ui/gtk-gl-area: Render guest content with padding in fixed-scale >>>> mode >>>> ui/gtk-egl: Render guest content with padding in fixed-scale >>>> mode > ... >> I think the first five patches are good candidates for backporting to >> the stable branches, as they only address bugs without altering >> existing behavior. [...] > > It somehow feels like *all* patches should be picked up, not just first > 5 of them :) BTW, the first one (Document scale handling) does not fix > any bugs ;) >
Great! Please apply all these patches to 10.0 branch. Let me know if there's anything I can help with. Best regards, Weifeng
