>-----Original Message----- >From: Steve Sistare <steven.sist...@oracle.com> >Subject: [PATCH] vfio/container: set error on cpr failure > >Set an error message if vfio_cpr_ram_discard_register_listener fails so >the fail label gets a valid error object. > >Reported-by: Cédric Le Goater <c...@redhat.com> >Fixes: eba1f657cbb1 ("vfio/container: recover from unmap-all-vaddr failure") >Signed-off-by: Steve Sistare <steven.sist...@oracle.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.d...@intel.com> Zhenzhong >--- > hw/vfio/listener.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c >index f498e23..5ebafaa 100644 >--- a/hw/vfio/listener.c >+++ b/hw/vfio/listener.c >@@ -574,6 +574,9 @@ void vfio_container_region_add(VFIOContainerBase >*bcontainer, > vfio_ram_discard_register_listener(bcontainer, section); > } else if (!vfio_cpr_ram_discard_register_listener(bcontainer, > >section)) { >+ error_setg(&err, >+ "vfio_cpr_ram_discard_register_listener for %s >failed", >+ memory_region_name(section->mr)); > goto fail; > } > return; >-- >1.8.3.1